Skip to content

Comments

test(minifier): merge variable declarations into for statement initializers#13770

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-15-fix_minifier_don_t_merge_variable_declarations_into_for_statement_initializers_unless_it_s_a_literal_value
Sep 15, 2025
Merged

test(minifier): merge variable declarations into for statement initializers#13770
graphite-app[bot] merged 1 commit intomainfrom
09-15-fix_minifier_don_t_merge_variable_declarations_into_for_statement_initializers_unless_it_s_a_literal_value

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Sep 15, 2025 •
edited
Loading

Added some test cases that describes that the transformations are safe, which I misunderstood once.

@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Sep 15, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red mentioned this pull request Sep 15, 2025
Merged
@github-actions github-actions bot added A-minifier Area - Minifier C-bug Category - Bug labels Sep 15, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 15, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #13770 will not alter performance

Comparing 09-15-fix_minifier_don_t_merge_variable_declarations_into_for_statement_initializers_unless_it_s_a_literal_value (fcc3663) with main (6f26cf0)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on main (fcc3663) during the generation of this report, so 6f26cf0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@sapphi-red sapphi-red force-pushed the 09-15-fix_minifier_don_t_inline_single_use_variables_that_are_not_literals_to_for_statement_initializers branch from 5532789 to 94b2953 Compare September 15, 2025 05:38
@sapphi-red sapphi-red force-pushed the 09-15-fix_minifier_don_t_merge_variable_declarations_into_for_statement_initializers_unless_it_s_a_literal_value branch from 9401066 to 0df1883 Compare September 15, 2025 05:38
@sapphi-red sapphi-red changed the title fix(minifier): don't merge variable declarations into for statement initializers unless it's a literal value test(minifier): merge variable declarations into for statement initializers Sep 15, 2025
@sapphi-red sapphi-red added C-test Category - Testing. Code is missing test cases, or a PR is adding them and removed C-bug Category - Bug labels Sep 15, 2025
@sapphi-red sapphi-red marked this pull request as ready for review September 15, 2025 05:41
@sapphi-red sapphi-red requested a review from Boshen September 15, 2025 05:42
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 15, 2025
@Boshen Graphite App
Copy link
Member

Boshen commented Sep 15, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot changed the base branch from 09-15-fix_minifier_don_t_inline_single_use_variables_that_are_not_literals_to_for_statement_initializers to graphite-base/13770 September 15, 2025 06:00
@graphite-app graphite-app bot changed the base branch from graphite-base/13770 to main September 15, 2025 06:05
@sapphi-red
test(minifier): merge variable declarations into for statement initia…
fcc3663 
…lizers (#13770)

Added some test cases that describes that the transformations are safe, which I misunderstood once.
@graphite-app graphite-app bot force-pushed the 09-15-fix_minifier_don_t_merge_variable_declarations_into_for_statement_initializers_unless_it_s_a_literal_value branch from 0df1883 to fcc3663 Compare September 15, 2025 06:06
@graphite-app graphite-app bot merged commit fcc3663 into main Sep 15, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 09-15-fix_minifier_don_t_merge_variable_declarations_into_for_statement_initializers_unless_it_s_a_literal_value branch September 15, 2025 06:12
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 15, 2025
@Boshen Boshen mentioned this pull request Sep 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Awaiting requested review from Boshen

Assignees

@Boshen Boshen

Labels

A-minifier Area - Minifier C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @Boshen