refactor(transformer, estree): clarify code using is_exhausted stack methods#13674
Merged
graphite-app[bot] merged 1 commit intomainfrom Sep 11, 2025
Conversation
github-actions
bot
added
A-transformer
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #13674 will not alter performanceComparing Summary
Footnotes |
overlookmotel
force-pushed
the
09-11-refactor_transformer_estree_clarify_code_using_is_exhausted_stack_methods
branch
from
9aa4d96 to
a461bb1
Compare
overlookmotel
force-pushed
the
09-11-refactor_data_structures_make_nonemptystack_is_empty_a_compile-time_error
branch
from
71381d1 to
41f48d5
Compare
graphite-app
bot
changed the base branch from
09-11-refactor_data_structures_make_nonemptystack_is_empty_a_compile-time_error
to
graphite-base/13674
Dunqing
approved these changes
Sep 11, 2025
Member
Merge activity
|
graphite-app
bot
force-pushed
the
09-11-refactor_transformer_estree_clarify_code_using_is_exhausted_stack_methods
branch
from
a461bb1 to
08cbd39
Compare
graphite-app
bot
deleted the
09-11-refactor_transformer_estree_clarify_code_using_is_exhausted_stack_methods
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utilize
is_exhaustedmethods ofNonEmptyStackandSparseStack(added in #13672) in transformer andoxc_estreeto clarify what these checks are doing.