refactor(data_structures)!: make NonEmptyStack::is_empty a compile-time error#13673
Merged
graphite-app[bot] merged 1 commit intomainfrom Sep 11, 2025
Conversation
github-actions
bot
added
the
C-cleanup
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #13673 will not alter performanceComparing Summary
Footnotes |
overlookmotel
force-pushed
the
09-11-feat_data_structures_add_is_exhausted_method_to_nonemptystack_and_sparsestack_
branch
from
d39f9d7 to
a6e1ace
Compare
overlookmotel
force-pushed
the
09-11-refactor_data_structures_make_nonemptystack_is_empty_a_compile-time_error
branch
from
71381d1 to
41f48d5
Compare
Member
Author
Merge activity
|
…time error (#13673) Continuation from #13672. Calling `NonEmptyStack::is_empty` is always a logic error. `NonEmptyStack` can never be empty, and `NonEmptyStack::is_exhausted` is very likely what was intended. Make calling `NonEmptyStack::is_empty` a compile-time error, to prevent this erroneous usage. Ideally, we'd remove the method entirely, but `&NonEmptyStack<T>` derefs to `&[T]`, so without defining `is_empty` method on `NonEmptyStack`, `stack.is_empty()` falls through to `[T]::is_empty`, which is not what we want.
graphite-app
bot
force-pushed
the
09-11-feat_data_structures_add_is_exhausted_method_to_nonemptystack_and_sparsestack_
branch
from
a6e1ace to
1a58e99
Compare
graphite-app
bot
force-pushed
the
09-11-refactor_data_structures_make_nonemptystack_is_empty_a_compile-time_error
branch
from
41f48d5 to
e433633
Compare
Base automatically changed from
09-11-feat_data_structures_add_is_exhausted_method_to_nonemptystack_and_sparsestack_
to
main
September 11, 2025 06:11
graphite-app
bot
deleted the
09-11-refactor_data_structures_make_nonemptystack_is_empty_a_compile-time_error
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation from #13672.
Calling
NonEmptyStack::is_emptyis always a logic error.NonEmptyStackcan never be empty, andNonEmptyStack::is_exhaustedis very likely what was intended.Make calling
NonEmptyStack::is_emptya compile-time error, to prevent this erroneous usage.Ideally, we'd remove the method entirely, but
&NonEmptyStack<T>derefs to&[T], so without definingis_emptymethod onNonEmptyStack,stack.is_empty()falls through to[T]::is_empty, which is not what we want.