Skip to content

Comments

fix(minifier): avoid inlining single use variables when the name needs to be preserved#13422

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-30-fix_minifier_avoid_inlining_single_use_variables_when_the_name_needs_to_be_preserved
Aug 30, 2025
Merged

fix(minifier): avoid inlining single use variables when the name needs to be preserved#13422
graphite-app[bot] merged 1 commit intomainfrom
08-30-fix_minifier_avoid_inlining_single_use_variables_when_the_name_needs_to_be_preserved

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 30, 2025

Made the single use variable inlining to respect keep_names option.

refs rolldown/rolldown#5975 (comment)

Copy link
Member Author

sapphi-red commented Aug 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-minifier Area - Minifier C-bug Category - Bug labels Aug 30, 2025
@sapphi-red sapphi-red marked this pull request as ready for review August 30, 2025 10:33
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 30, 2025

CodSpeed Instrumentation Performance Report

Merging #13422 will degrade performances by 6.2%

Comparing 08-30-fix_minifier_avoid_inlining_single_use_variables_when_the_name_needs_to_be_preserved (6d0e355) with main (3f3b93d)1

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 35 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[RadixUIAdoptionSection.jsx] 14.2 µs 15.2 µs -6.2%
mangler[cal.com.tsx] 3.8 ms 3.4 ms +11.44%

Footnotes

  1. No successful run was found on main (6d0e355) during the generation of this report, so 3f3b93d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 30, 2025
Copy link
Member

Boshen commented Aug 30, 2025

Merge activity

…s to be preserved (#13422)

Made the single use variable inlining to respect `keep_names` option.

refs rolldown/rolldown#5975 (comment)
@graphite-app graphite-app bot force-pushed the 08-30-fix_mangler_keep_names_for_parenthesized_functions_and_classes branch from 2d79c82 to e3f953d Compare August 30, 2025 11:10
@graphite-app graphite-app bot force-pushed the 08-30-fix_minifier_avoid_inlining_single_use_variables_when_the_name_needs_to_be_preserved branch from c793ff7 to 6d0e355 Compare August 30, 2025 11:11
Base automatically changed from 08-30-fix_mangler_keep_names_for_parenthesized_functions_and_classes to main August 30, 2025 11:15
@graphite-app graphite-app bot merged commit 6d0e355 into main Aug 30, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-30-fix_minifier_avoid_inlining_single_use_variables_when_the_name_needs_to_be_preserved branch August 30, 2025 11:16
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants