refactor(ecmascript)!: remove PropertyReadSideEffects::OnlyMemberPropertyAccess#13348
Conversation
github-actions
bot
added
A-minifier
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #13348 will not alter performanceComparing Summary
Footnotes |
|
https://deepwiki.com/search/what-is-the-difference-between_7a582090-34a7-4c97-a981-9bd6deeee882, here is the example deepwiki explained what is the difference between |
Merge activity
|
…pertyAccess` (#13348) In #10129, I introduced `PropertyReadSideEffects`. In that, I added `PropertyReadSideEffects::OnlyMemberPropertyAccess`. This was because I thought this was the default behavior of Rollup at that time. But after re-reading the Rollup's code and checking the behavior in REPL while reviewing rolldown/rolldown#5945, I noticed that I was wrong. Since this was added solely for Rolldown to add support for `treeshake.propertyReadSideEffects` and it's not useful for that usecase, I removed the value. cc @IWANABETHATGUY
graphite-app
bot
force-pushed
the
08-28-refactor_ecmascript_remove_propertyreadsideeffects_onlymemberpropertyaccess_
branch
from
5f153fd to
e459866
Compare
graphite-app
bot
deleted the
08-28-refactor_ecmascript_remove_propertyreadsideeffects_onlymemberpropertyaccess_
branch
2 participants
In #10129, I introduced
PropertyReadSideEffects. In that, I addedPropertyReadSideEffects::OnlyMemberPropertyAccess. This was because I thought this was the default behavior of Rollup at that time.But after re-reading the Rollup's code and checking the behavior in REPL while reviewing rolldown/rolldown#5945, I noticed that I was wrong. Since this was added solely for Rolldown to add support for
treeshake.propertyReadSideEffectsand it's not useful for that usecase, I removed the value.cc @IWANABETHATGUY