Skip to content

Comments

chore(oxc_minify_napi): expose more options struct#13239

Merged
Boshen merged 1 commit intomainfrom
08-20-chore_oxc_minify_napi_expose_more_struct
Aug 20, 2025
Merged

chore(oxc_minify_napi): expose more options struct#13239
Boshen merged 1 commit intomainfrom
08-20-chore_oxc_minify_napi_expose_more_struct

Conversation

@IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Aug 20, 2025 •
edited
Loading

Allow the downstream user to construct a napi options on their own, a use case in rolldown https://github.com/rolldown/rolldown/pull/5804/files#diff-56038ed67657ce910f150123cdc2d8ab42bd9bcd9745192c3127f2d837c78865R248, we need to convert options back to oxc_minify_napi, since oxc::minify::options did not implement toNapi trait.

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review August 20, 2025 14:38
Copilot AI review requested due to automatic review settings August 20, 2025 14:38
Copilot AI reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exposes additional minify-related struct types in the NAPI bindings for the oxc_minify library. The change makes compress and mangle options structs publicly available through the library's API.

  • Expands the public API by exposing CompressOptions, CompressOptionsKeepNames, MangleOptions, and MangleOptionsKeepNames structs
  • Updates the module's public exports to include these additional option types alongside the existing MinifyOptions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@IWANABETHATGUY Graphite App
Copy link
Contributor Author

IWANABETHATGUY commented Aug 20, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Aug 20, 2025
@IWANABETHATGUY IWANABETHATGUY changed the title chore(oxc_minify_napi): expose more struct chore(oxc_minify_napi): expose more options struct Aug 20, 2025
@Boshen Boshen merged commit d86f732 into main Aug 20, 2025
18 checks passed
@Boshen Boshen deleted the 08-20-chore_oxc_minify_napi_expose_more_struct branch August 20, 2025 15:18
@sapphi-red sapphi-red mentioned this pull request Aug 25, 2025
Merged
graphite-app bot pushed a commit that referenced this pull request Aug 25, 2025
@sapphi-red
feat(oxc_minify_napi): expose CodeGenOptions (#13288)
a0e0a91 
Follow up to #13239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @Boshen