Skip to content

Comments

feat(codegen): keep function expression PIFEs#12470

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-23-feat_codegen_keep_function_expression_pifes
Jul 24, 2025
Merged

feat(codegen): keep function expression PIFEs#12470
graphite-app[bot] merged 1 commit intomainfrom
07-23-feat_codegen_keep_function_expression_pifes

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 23, 2025

Made function expression PIFEs to be kept. Similar to #12353 but for function expressions.

The minsize for victory is bigger because webpack's output contains many PIFEs (some shouldn't be written as PIFEs though).

refs #12353

@github-actions github-actions bot added A-parser Area - Parser A-minifier Area - Minifier A-codegen Area - Code Generation C-enhancement Category - New feature or request labels Jul 23, 2025
Copy link
Member Author

sapphi-red commented Jul 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red marked this pull request as ready for review July 23, 2025 11:08
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 23, 2025

CodSpeed Instrumentation Performance Report

Merging #12470 will not alter performance

Comparing 07-23-feat_codegen_keep_function_expression_pifes (c135beb) with 07-23-feat_ast_add_pife_field_to_function_ (dee25f4)

Summary

✅ 34 untouched benchmarks

@sapphi-red sapphi-red marked this pull request as draft July 23, 2025 11:16
@sapphi-red sapphi-red force-pushed the 07-23-feat_codegen_keep_function_expression_pifes branch from 0e66372 to 395cfe3 Compare July 23, 2025 11:58
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Jul 23, 2025
@sapphi-red sapphi-red force-pushed the 07-23-feat_codegen_keep_function_expression_pifes branch from 8090bb2 to 67f7be4 Compare July 23, 2025 12:11
@sapphi-red sapphi-red marked this pull request as ready for review July 23, 2025 12:27
@Boshen Boshen self-assigned this Jul 23, 2025
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 24, 2025
Copy link
Member

Boshen commented Jul 24, 2025

Merge activity

Made function expression PIFEs to be kept. Similar to #12353 but for function expressions.

The minsize for victory is bigger because webpack's output contains many PIFEs (some shouldn't be written as PIFEs though).

refs #12353
@graphite-app graphite-app bot force-pushed the 07-23-feat_ast_add_pife_field_to_function_ branch from 3692e60 to dee25f4 Compare July 24, 2025 00:50
@graphite-app graphite-app bot force-pushed the 07-23-feat_codegen_keep_function_expression_pifes branch from 67f7be4 to c135beb Compare July 24, 2025 00:50
Base automatically changed from 07-23-feat_ast_add_pife_field_to_function_ to main July 24, 2025 00:57
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 24, 2025
@graphite-app graphite-app bot merged commit c135beb into main Jul 24, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 07-23-feat_codegen_keep_function_expression_pifes branch July 24, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation A-minifier Area - Minifier A-parser Area - Parser A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants