perf(codegen): remove the useless tokens generated by some expressions#12394
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 20, 2025
Merged
perf(codegen): remove the useless tokens generated by some expressions#12394graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-codegen
CodSpeed Instrumentation Performance ReportMerging #12394 will not alter performanceComparing Summary
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Boshen
changed the title
Member
Author
Merge activity
|
graphite-app
bot
force-pushed
the
perf-sourmap
branch
from
582a665 to
8bae417
Compare
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Jul 20, 2025
This upgrade adds * oxc-project/oxc#12353 * oxc-project/oxc#12373 * oxc-project/oxc#12393 * oxc-project/oxc#12394 * oxc-project/oxc#12398 * oxc-project/oxc-sourcemap#86 We should expect a small performance improvement when sourcemap is enabled.
| --- | ||
| - test.js.map | ||
| (0:0) "1;\n" --> (0:0) "1;\n" | ||
| (1:0) "__OBJECT__;\n" --> (1:0) "({ 'hello': 'test' });\n" |
Member
There was a problem hiding this comment.
This doesn't look right. I assume there should be a mapping for this? Or is the fault in ReplaceGlobalDefines?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.