Skip to content

Comments

perf(codegen): remove clone of source text in sourcemap builder#12393

Merged
Boshen merged 1 commit intomainfrom
remove-sourcemap-clone
Jul 18, 2025
Merged

perf(codegen): remove clone of source text in sourcemap builder#12393
Boshen merged 1 commit intomainfrom
remove-sourcemap-clone

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jul 18, 2025

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-codegen Area - Code Generation C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 18, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 18, 2025

CodSpeed Instrumentation Performance Report

Merging #12393 will improve performances by 8.04%

Comparing remove-sourcemap-clone (4b7596c) with main (4621872)1

Summary

⚡ 3 improvements
✅ 31 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
codegen[binder.ts] 4.8 ms 4.5 ms +8.04%
codegen[cal.com.tsx] 39.3 ms 37.9 ms +3.78%
codegen[react.development.js] 2.2 ms 2.1 ms +6.26%

Footnotes

  1. No successful run was found on main (46e33d5) during the generation of this report, so 4621872 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen merged commit 8917a5f into main Jul 18, 2025
24 checks passed
@Boshen Boshen deleted the remove-sourcemap-clone branch July 18, 2025 16:23
@Boshen Boshen changed the title refactor(codegen): remove clone of source text in sourcemap builder perf(codegen): remove clone of source text in sourcemap builder Jul 20, 2025
@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Jul 20, 2025
github-merge-queue bot pushed a commit to rolldown/rolldown that referenced this pull request Jul 20, 2025
This upgrade adds

* oxc-project/oxc#12353
* oxc-project/oxc#12373
* oxc-project/oxc#12393
* oxc-project/oxc#12394
* oxc-project/oxc#12398
* oxc-project/oxc-sourcemap#86

We should expect a small performance improvement when sourcemap is
enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant