Skip to content

feat(linter): load custom JS plugins configured in overrides#12324

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/07-16-feat_linter_load_custom_js_plugins_configured_in_overrides
Jul 16, 2025
Merged

feat(linter): load custom JS plugins configured in overrides#12324
graphite-app[bot] merged 1 commit intomainfrom
c/07-16-feat_linter_load_custom_js_plugins_configured_in_overrides

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Jul 16, 2025

No description provided.

@camc314 camc314 marked this pull request as ready for review July 16, 2025 14:58
Copy link
Copy Markdown
Contributor Author

camc314 commented Jul 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Jul 16, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jul 16, 2025

CodSpeed Instrumentation Performance Report

Merging #12324 will not alter performance

Comparing c/07-16-feat_linter_load_custom_js_plugins_configured_in_overrides (4f50750) with main (21e8f0a)

Summary

✅ 34 untouched benchmarks

Copy link
Copy Markdown
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a couple of commits for trivial refactor.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 16, 2025
Copy link
Copy Markdown
Member

overlookmotel commented Jul 16, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/07-16-feat_linter_load_custom_js_plugins_configured_in_overrides branch from 479b818 to 4f50750 Compare July 16, 2025 16:17
@graphite-app graphite-app bot merged commit 4f50750 into main Jul 16, 2025
24 checks passed
@graphite-app graphite-app bot deleted the c/07-16-feat_linter_load_custom_js_plugins_configured_in_overrides branch July 16, 2025 16:26
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 16, 2025
@Hideman42
Copy link
Copy Markdown

Hi @camc314 what an amazing news in this release 💯
I was trying directly based on the e2e test you written to use my first js plugin in the 1.7.0 but got the following:

 × Failed to load external plugin because no external linter was configured. This means the Oxlint binary was executed directly rather than via napi bindings.

Based on my understanding it is because we are needing the following https://github.com/oxc-project/oxc/blob/main/napi/oxlint2/package.json do you think a preview release could be made on npm?
This would be really awesome for trying around 🙌

@camc314
Copy link
Copy Markdown
Contributor Author

camc314 commented Jul 21, 2025

Thank you. We are still working to finalize the feature, and fix some of the missing pieces. once that work is done, we will do a preview release allowing you to try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants