Skip to content

Comments

refactor(transformer/styled-components): simplify concating strs#12183

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-10-refactor_transformer_styled-components_simplify_concating_strs
Jul 10, 2025
Merged

refactor(transformer/styled-components): simplify concating strs#12183
graphite-app[bot] merged 1 commit intomainfrom
07-10-refactor_transformer_styled-components_simplify_concating_strs

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 10, 2025 •
edited
Loading

atom_from_strs_array returns an Atom, but we only need a str here, so using alloc_concat_strs_array is better.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Jul 10, 2025
@Dunqing Dunqing mentioned this pull request Jul 10, 2025
Merged
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jul 10, 2025
This was referenced Jul 10, 2025
Merged
Merged
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Jul 10, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 10, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #12183 will not alter performance

Comparing 07-10-refactor_transformer_styled-components_simplify_concating_strs (94796a0) with main (a6ee13a)

Summary

✅ 34 untouched benchmarks

@Dunqing Dunqing marked this pull request as ready for review July 10, 2025 06:22
@Dunqing Dunqing requested a review from overlookmotel as a code owner July 10, 2025 06:22
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 10, 2025
@overlookmotel Graphite App
Copy link
Member

overlookmotel commented Jul 10, 2025 •
edited by graphite-app bot
Loading

Merge activity

@Dunqing
refactor(transformer/styled-components): simplify concating strs (#12183
94796a0 
)

`atom_from_strs_array` returns an `Atom`, but we only need a `str` here, so using `alloc_concat_strs_array` is better.
@graphite-app graphite-app bot force-pushed the 07-10-docs_transformer_styled-components_add_some_comments branch from 765bfca to 59616ca Compare July 10, 2025 08:54
@graphite-app graphite-app bot force-pushed the 07-10-refactor_transformer_styled-components_simplify_concating_strs branch from fe9ca27 to 94796a0 Compare July 10, 2025 08:54
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 10, 2025
Base automatically changed from 07-10-docs_transformer_styled-components_add_some_comments to main July 10, 2025 09:02
@graphite-app graphite-app bot merged commit 94796a0 into main Jul 10, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 07-10-refactor_transformer_styled-components_simplify_concating_strs branch July 10, 2025 09:03
@oxc-bot oxc-bot mentioned this pull request Jul 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees

No one assigned

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dunqing @overlookmotel