Skip to content

Comments

refactor(transformer/plugins): don't store PluginOptions#12180

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-10-refactor_transformer_plugins_only_store_pluginoptions_once
Jul 10, 2025
Merged

refactor(transformer/plugins): don't store PluginOptions#12180
graphite-app[bot] merged 1 commit intomainfrom
07-10-refactor_transformer_plugins_only_store_pluginoptions_once

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 10, 2025

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 10, 2025
Copy link
Member Author

Dunqing commented Jul 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 10, 2025

CodSpeed Instrumentation Performance Report

Merging #12180 will not alter performance

Comparing 07-10-refactor_transformer_plugins_only_store_pluginoptions_once (a6ee13a) with main (466241d)

Summary

✅ 34 untouched benchmarks

@Dunqing Dunqing changed the title refactor(transformer/plugins): only store PluginOptions once refactor(transformer/plugins): don't store PluginOptions Jul 10, 2025
@Dunqing Dunqing marked this pull request as ready for review July 10, 2025 06:14
@Dunqing Dunqing requested a review from overlookmotel as a code owner July 10, 2025 06:14
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 10, 2025
Copy link
Member

overlookmotel commented Jul 10, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 07-10-refactor_transformer_plugins_only_store_pluginoptions_once branch from a7bd6e2 to a6ee13a Compare July 10, 2025 08:42
@graphite-app graphite-app bot merged commit a6ee13a into main Jul 10, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 07-10-refactor_transformer_plugins_only_store_pluginoptions_once branch July 10, 2025 08:51
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants