• perf(linter): experiment: skip rules when no nodes match #12178 👈 (View in Graphite)
• main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

This stack of pull requests is managed by Graphite. Learn more about stacking.

CodSpeed Instrumentation Performance Report

Merging #12178 will improve performances by 4.79%

_{Comparing 07-09-perf_linter_experiment_skip_rules_when_no_nodes_match (c4becbb) with main (466241d)}

Summary

⚡ 1 improvements
✅ 33 untouched benchmarks

Benchmarks breakdown

I converted two dozen or so rules that I saw in profiling initially. I'll add more to this as the initial results seem promising. On small files like the RadixUIAdoptionSection.jsx benchmark it is up to 5% faster on walltime. On larger files it is still an improvement as we can skip many node iterations potentially.

I would say this experiment was successful. I have some ideas on how to further improve this method, but I'll polish this up on a separate branch and split it up into a stack of PRs.