refactor(transformer/styled_components): make unreachable branch unreachable!#12172
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 10, 2025
Conversation
github-actions
bot
added
A-transformer
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12172 will not alter performanceComparing Summary
|
This was referenced Jul 9, 2025
Dunqing
approved these changes
Jul 10, 2025
Member
Dunqing
left a comment
Dunqing
left a comment
There was a problem hiding this comment.
I have been away the transformer too long...
Contributor
Merge activity
|
…eachable!` (#12172) This branch is unreachable, so use `unreachable!` for it, rather than `return`. Despite `unreachable!` producing more code, this may still be more performant, because it tells the compiler which branch is going to be taken. Compiler will generate assembly to make the branch which is taken the fast path. Either way, it's a micro micro optimization. Mainly I think it's preferable because it's clearer when reading the code.
graphite-app
bot
force-pushed
the
07-09-perf_transformer_styled_components_replace_hashmap_with_array
branch
from
a5ab429 to
bcd5094
Compare
graphite-app
bot
force-pushed
the
07-09-refactor_transformer_styled_components_make_unreachable_branch_unreachable_
branch
from
df98bf4 to
4e58a2a
Compare
Base automatically changed from
07-09-perf_transformer_styled_components_replace_hashmap_with_array
to
main
July 10, 2025 00:49
graphite-app
bot
deleted the
07-09-refactor_transformer_styled_components_make_unreachable_branch_unreachable_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is unreachable, so use
unreachable!for it, rather thanreturn.Despite
unreachable!producing more code, this may still be more performant, because it tells the compiler which branch is going to be taken. Compiler will generate assembly to make the branch which is taken the fast path. Either way, it's a micro micro optimization.Mainly I think it's preferable because it's clearer when reading the code.