perf(allocator): reduce operations while Mutex lock is held in AllocatorPool#11761
Merged
graphite-app[bot] merged 1 commit intomainfrom Jun 17, 2025
Conversation
github-actions
bot
added
the
C-performance
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11761 will improve performances by 15.05%Comparing Summary
Benchmarks breakdown
|
overlookmotel
changed the title
Mutex lock is heldMutex lock is held in AllocatorPool
overlookmotel
force-pushed
the
06-16-perf_allocator_reduce_operations_while_mutex_lock_is_held
branch
from
101bde6 to
d7a0d0c
Compare
overlookmotel
force-pushed
the
06-16-perf_allocator_remove_arc_from_allocatorpool_
branch
from
425def8 to
16281db
Compare
camc314
reviewed
Jun 16, 2025
camc314
approved these changes
Jun 16, 2025
overlookmotel
force-pushed
the
06-16-perf_allocator_reduce_operations_while_mutex_lock_is_held
branch
from
d7a0d0c to
bb25d9c
Compare
overlookmotel
force-pushed
the
06-16-perf_allocator_remove_arc_from_allocatorpool_
branch
from
16281db to
cdc2877
Compare
graphite-app
bot
changed the base branch from
06-16-perf_allocator_remove_arc_from_allocatorpool_
to
graphite-base/11761
graphite-app
bot
force-pushed
the
06-16-perf_allocator_reduce_operations_while_mutex_lock_is_held
branch
from
bb25d9c to
ea5137e
Compare
graphite-app
bot
force-pushed
the
graphite-base/11761
branch
from
cdc2877 to
f539f64
Compare
graphite-app
bot
force-pushed
the
06-16-perf_allocator_reduce_operations_while_mutex_lock_is_held
branch
from
ea5137e to
d8e63cc
Compare
Member
Author
Merge activity
|
…ocatorPool` (#11761) Tiny optimization to `AllocatorPool`. `unwrap_or_else` doesn't require the mutex lock, so drop the lock before calling it.
graphite-app
bot
force-pushed
the
06-16-perf_allocator_reduce_operations_while_mutex_lock_is_held
branch
from
d8e63cc to
2641030
Compare
graphite-app
bot
deleted the
06-16-perf_allocator_reduce_operations_while_mutex_lock_is_held
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny optimization to
AllocatorPool.unwrap_or_elsedoesn't require the mutex lock, so drop the lock before calling it.