• perf(parser): improve perf of parse_template_lit #11542 👈 (View in Graphite)
• fix(parser): report error on malformed template expressions #11540
• fix(parser): correct TemplateTail::to_str from $} to } #11539
• main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

This stack of pull requests is managed by Graphite. Learn more about stacking.

CodSpeed Instrumentation Performance Report

Merging #11542 will degrade performances by 5.56%

_{Comparing c/06-07-perf_parser_improve_perf_of_parse_tempalte_lit (f224585) with main (7bf25cb)}

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

difference feels negligible, although this definitly does reduce some .grow_one calls + some allocations

note in the benchmarks, RadixUIAdoptionSection.jsx and react.development.js have no template lit strings, so no perf change is expected ther

will leave up to Boshen/overlookmotel to decide if it's worth merging

Merge activity

• Jun 9, 10:19 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jun 9, 10:19 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Jun 9, 10:26 AM UTC: Merged by the Graphite merge queue.

Nice find!