Skip to content

fix(parser): report error on malformed template expressions#11540

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/06-07-fix_parser_report_error_on_malformed_template_expressions
Jun 8, 2025
Merged

fix(parser): report error on malformed template expressions#11540
graphite-app[bot] merged 1 commit intomainfrom
c/06-07-fix_parser_report_error_on_malformed_template_expressions

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Jun 7, 2025

fixes #11538

Copy link
Copy Markdown
Contributor Author

camc314 commented Jun 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 7, 2025

CodSpeed Instrumentation Performance Report

Merging #11540 will degrade performances by 22.86%

Comparing c/06-07-fix_parser_report_error_on_malformed_template_expressions (cb17dae) with main (fa924ab)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 2.7 ms 3.5 ms -22.86%

@camc314 camc314 marked this pull request as ready for review June 7, 2025 12:20
@camc314 camc314 marked this pull request as draft June 7, 2025 12:25
@camc314 camc314 marked this pull request as ready for review June 7, 2025 12:57
@camc314 camc314 force-pushed the c/06-07-fix_parser_report_error_on_malformed_template_expressions branch from 1b3c689 to def62f7 Compare June 7, 2025 12:57
@camc314 camc314 changed the base branch from c/06-07-fix_parser_correct_templatetail_to_str_from_to_ to graphite-base/11540 June 7, 2025 13:33
@camc314 camc314 requested a review from Boshen June 7, 2025 13:51
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 7, 2025
Copy link
Copy Markdown
Member

Boshen commented Jun 7, 2025

Merge activity

  • Jun 7, 2:19 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 7, 2:27 PM UTC: Boshen added this pull request to the Graphite merge queue.
  • Jun 7, 2:43 PM UTC: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Jun 8, 11:40 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 8, 11:46 AM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jun 8, 11:53 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from graphite-base/11540 to main June 7, 2025 14:41
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 7, 2025
@camc314 camc314 force-pushed the c/06-07-fix_parser_report_error_on_malformed_template_expressions branch from def62f7 to 4d49760 Compare June 8, 2025 11:39
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 8, 2025
@graphite-app graphite-app bot force-pushed the c/06-07-fix_parser_report_error_on_malformed_template_expressions branch from 4d49760 to cb17dae Compare June 8, 2025 11:46
@graphite-app graphite-app bot merged commit cb17dae into main Jun 8, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 8, 2025
@graphite-app graphite-app bot deleted the c/06-07-fix_parser_report_error_on_malformed_template_expressions branch June 8, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parser: false positive when parsing template lit expressions

2 participants