Skip to content

Comments

fix(transformer/module_runner): fix export default live binding#10560

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-23-fix_transformer_module_runner_fix_export_default_live_binding
Apr 23, 2025
Merged

fix(transformer/module_runner): fix export default live binding#10560
graphite-app[bot] merged 1 commit intomainfrom
04-23-fix_transformer_module_runner_fix_export_default_live_binding

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Apr 23, 2025

Aligning with vitejs/vite#19842 (Hopefully this is the last one 🙂)

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Apr 23, 2025
Copy link
Contributor Author

hi-ogawa commented Apr 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 23, 2025

CodSpeed Instrumentation Performance Report

Merging #10560 will create unknown performance changes

Comparing 04-23-fix_transformer_module_runner_fix_export_default_live_binding (84742d8) with main (6c115c7)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.1 ms N/A
🆕 formatter[antd.js] N/A 708.4 ms N/A
🆕 formatter[react.development.js] N/A 8 ms N/A
🆕 formatter[typescript.js] N/A 1.1 s N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.3 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.9 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3 s N/A
🆕 mangler[antd.js] N/A 15.9 ms N/A
🆕 mangler[react.development.js] N/A 292.9 µs N/A
🆕 mangler[typescript.js] N/A 39.4 ms N/A
🆕 minifier[antd.js] N/A 163.6 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 288 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@hi-ogawa hi-ogawa force-pushed the 04-23-fix_transformer_module_runner_fix_export_default_live_binding branch from 803ac73 to 32eb0a5 Compare April 23, 2025 09:21
@hi-ogawa hi-ogawa force-pushed the 04-11-fix_transformer_module_runner_fix_execution_order_of_re-export branch from eb16aa2 to 8a49752 Compare April 23, 2025 09:21
@hi-ogawa hi-ogawa marked this pull request as ready for review April 23, 2025 09:28
@Dunqing Dunqing removed the request for review from overlookmotel April 23, 2025 09:33
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Apr 23, 2025
Copy link
Member

Dunqing commented Apr 23, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 04-11-fix_transformer_module_runner_fix_execution_order_of_re-export branch from 8a49752 to 6c115c7 Compare April 23, 2025 10:07
@graphite-app graphite-app bot force-pushed the 04-23-fix_transformer_module_runner_fix_export_default_live_binding branch from 1ab85d4 to 84742d8 Compare April 23, 2025 10:08
Base automatically changed from 04-11-fix_transformer_module_runner_fix_execution_order_of_re-export to main April 23, 2025 10:15
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 23, 2025
@Dunqing
Copy link
Member

Dunqing commented Apr 23, 2025

This is a fairly stretched edge case, but just found that Oxc uses Object.defineProperty(..., { get: ... }) while Vite uses Object.defineProperty(..., { value: ... }) and Oxc's implementation seems to be actually correct one.

I wasn't aware that my mistake was actually right.😅

@graphite-app graphite-app bot merged commit 84742d8 into main Apr 23, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 04-23-fix_transformer_module_runner_fix_export_default_live_binding branch April 23, 2025 10:21
Boshen added a commit that referenced this pull request Apr 23, 2025
## [0.66.0] - 2025-04-23

### Features

- 7d5ad7d parser: Report error when `import type { type }` is used
(#10528) (camc314)
- 6e40fac parser: Report error when `export type { type }` is used
(#10524) (camc314)

### Bug Fixes

- 43ad4e9 ast: Box `this_param` in `TSCallSignatureDeclaration` (#10558)
(Yuji Sugiura)
- 8eb3c0a ast/estree: Fix raw deser for `FormalParameter` (#10548)
(overlookmotel)
- 3ebf220 codegen: Generate missing `type` in `export type {} from
'mod'` (#10539) (Boshen)
- f19b287 estree: Add `TSParameterProperty` (#10534) (Yuji Sugiura)
- 7284f16 isolated-declarations: Leading comments of
`ExportDefaultDeclaration` and `TSExportAssignment` appear in incorrect
places (#10559) (Dunqing)
- 4c316a5 isolated_declarations: Fix broken snapshot files (#10561)
(Boshen)
- 84742d8 transformer/module_runner: Fix export default live binding
(#10560) (hi-ogawa)
- 6c115c7 transformer/module_runner: Fix execution order of re-export
(#10362) (hi-ogawa)
- b9d84b0 transformer/typescript: Remove `StringLiteral::raw` when
rewriting extensions (#10554) (overlookmotel)

### Performance

- 6a045c8 codegen: Speed up printing `Directive`s (#10551)
(overlookmotel)
- 3418ae5 transformer/class-properties: Re-use
`InstanceInitializerVisitor` (#10543) (overlookmotel)
- 7fcf0ac transformer/typescript: Reduce allocations renaming extensions
(#10555) (overlookmotel)

### Documentation

- 1a9530c transformer/class-properties: Fix typo (#10542)
(overlookmotel)

### Refactor

- 7e71282 transformer/class-properties: Correct outdated comment
(#10546) (overlookmotel)
- 596978b transformer/class-properties: Simplify to get `constructor`
method only once (#10493) (Dunqing)
- f13fe0a transformer/class-properties: Defer re-parenting initializers
scopes until all instance properties are transformed (#10495) (Dunqing)
- c83dad6 transformer/class-properties: Streamline handling scope of
instance property initializer (#10492) (Dunqing)

### Styling

- e10dfc8 traverse: Remove excess whitespace (#10544) (overlookmotel)

### Testing

- 227febf allocator: Ignore a slow doc test (#10521) (Dunqing)
- 14bb2be codegen: Add more tests for strings (#10552) (overlookmotel)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants