Skip to content

Comments

fix(estree): Add missing fields for RestElement raw deser#10557

Merged
overlookmotel merged 2 commits intomainfrom
fix/restelement
Apr 23, 2025
Merged

fix(estree): Add missing fields for RestElement raw deser#10557
overlookmotel merged 2 commits intomainfrom
fix/restelement

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Apr 23, 2025

I happened to find this when checking #10548 👀

(It might not have been necessary to fix it right away, but since I found it 😅)

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Apr 23, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 23, 2025

CodSpeed Instrumentation Performance Report

Merging #10557 will not alter performance

Comparing fix/restelement (8148eba) with main (7fcf0ac)

Summary

✅ 36 untouched benchmarks

Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 23, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 23, 2025

Merge activity

  • Apr 23, 12:49 PM UTC: @leaysgur we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 23, 2025
@overlookmotel overlookmotel merged commit 198827c into main Apr 23, 2025
29 checks passed
@overlookmotel overlookmotel deleted the fix/restelement branch April 23, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants