Skip to content

Comments

fix(codegen): generate missing type in export type {} from 'mod'#10539

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-22-fix_codegen_generate_missing_type_in_export_type_from_mod_
Apr 22, 2025
Merged

fix(codegen): generate missing type in export type {} from 'mod'#10539
graphite-app[bot] merged 1 commit intomainfrom
04-22-fix_codegen_generate_missing_type_in_export_type_from_mod_

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Apr 22, 2025

fixes #10465

@github-actions github-actions bot added A-codegen Area - Code Generation C-bug Category - Bug labels Apr 22, 2025
Copy link
Member Author

Boshen commented Apr 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 22, 2025

CodSpeed Instrumentation Performance Report

Merging #10539 will not alter performance

Comparing 04-22-fix_codegen_generate_missing_type_in_export_type_from_mod_ (3ebf220) with main (6908bc3)

Summary

✅ 36 untouched benchmarks

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 22, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 04-22-fix_codegen_generate_missing_type_in_export_type_from_mod_ branch from d7c1df4 to 3ebf220 Compare April 22, 2025 08:18
@graphite-app graphite-app bot merged commit 3ebf220 into main Apr 22, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-22-fix_codegen_generate_missing_type_in_export_type_from_mod_ branch April 22, 2025 08:24
Boshen added a commit that referenced this pull request Apr 23, 2025
## [0.66.0] - 2025-04-23

### Features

- 7d5ad7d parser: Report error when `import type { type }` is used
(#10528) (camc314)
- 6e40fac parser: Report error when `export type { type }` is used
(#10524) (camc314)

### Bug Fixes

- 43ad4e9 ast: Box `this_param` in `TSCallSignatureDeclaration` (#10558)
(Yuji Sugiura)
- 8eb3c0a ast/estree: Fix raw deser for `FormalParameter` (#10548)
(overlookmotel)
- 3ebf220 codegen: Generate missing `type` in `export type {} from
'mod'` (#10539) (Boshen)
- f19b287 estree: Add `TSParameterProperty` (#10534) (Yuji Sugiura)
- 7284f16 isolated-declarations: Leading comments of
`ExportDefaultDeclaration` and `TSExportAssignment` appear in incorrect
places (#10559) (Dunqing)
- 4c316a5 isolated_declarations: Fix broken snapshot files (#10561)
(Boshen)
- 84742d8 transformer/module_runner: Fix export default live binding
(#10560) (hi-ogawa)
- 6c115c7 transformer/module_runner: Fix execution order of re-export
(#10362) (hi-ogawa)
- b9d84b0 transformer/typescript: Remove `StringLiteral::raw` when
rewriting extensions (#10554) (overlookmotel)

### Performance

- 6a045c8 codegen: Speed up printing `Directive`s (#10551)
(overlookmotel)
- 3418ae5 transformer/class-properties: Re-use
`InstanceInitializerVisitor` (#10543) (overlookmotel)
- 7fcf0ac transformer/typescript: Reduce allocations renaming extensions
(#10555) (overlookmotel)

### Documentation

- 1a9530c transformer/class-properties: Fix typo (#10542)
(overlookmotel)

### Refactor

- 7e71282 transformer/class-properties: Correct outdated comment
(#10546) (overlookmotel)
- 596978b transformer/class-properties: Simplify to get `constructor`
method only once (#10493) (Dunqing)
- f13fe0a transformer/class-properties: Defer re-parenting initializers
scopes until all instance properties are transformed (#10495) (Dunqing)
- c83dad6 transformer/class-properties: Streamline handling scope of
instance property initializer (#10492) (Dunqing)

### Styling

- e10dfc8 traverse: Remove excess whitespace (#10544) (overlookmotel)

### Testing

- 227febf allocator: Ignore a slow doc test (#10521) (Dunqing)
- 14bb2be codegen: Add more tests for strings (#10552) (overlookmotel)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

codegen: failed to generate export type {} from 'mod'

1 participant