Skip to content

Comments

test(transformer/class-properties): overrides a few tests that contain class properties without initializer usages#10538

Closed
Dunqing wants to merge 1 commit intomainfrom
04-22-test_transformer_class-properties_overrides_a_few_tests_that_contain_class_properties_without_initializer_usages
Closed

test(transformer/class-properties): overrides a few tests that contain class properties without initializer usages#10538
Dunqing wants to merge 1 commit intomainfrom
04-22-test_transformer_class-properties_overrides_a_few_tests_that_contain_class_properties_without_initializer_usages

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 22, 2025 •
edited
Loading

Prepare for #10491. Since #10491 aligns the transforming behavior of properties without an initializer with TypeScript, these tests' output needs to be tweaked. To avoid producing an unreadable diff, we override the tests first, and then we can see only the changed parts from the diff in #10491.

This was referenced Apr 22, 2025
Closed
Merged
Merged
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Apr 22, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Apr 22, 2025
Merged
@Dunqing Dunqing marked this pull request as ready for review April 22, 2025 01:48
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Apr 22, 2025
@Dunqing Dunqing mentioned this pull request Apr 22, 2025
Merged
@overlookmotel overlookmotel force-pushed the 04-18-refactor_transformer_class-properties_simplify_to_get_construcot_method_only_once branch from f24f711 to aaa8993 Compare April 22, 2025 15:02
@overlookmotel overlookmotel force-pushed the 04-22-test_transformer_class-properties_overrides_a_few_tests_that_contain_class_properties_without_initializer_usages branch from 401943c to c9299a1 Compare April 22, 2025 15:02
@graphite-app graphite-app bot changed the base branch from 04-18-refactor_transformer_class-properties_simplify_to_get_construcot_method_only_once to graphite-base/10538 April 22, 2025 15:09
@graphite-app graphite-app bot force-pushed the 04-22-test_transformer_class-properties_overrides_a_few_tests_that_contain_class_properties_without_initializer_usages branch from c9299a1 to edb1aa9 Compare April 22, 2025 15:23
@graphite-app graphite-app bot force-pushed the graphite-base/10538 branch from aaa8993 to 596978b Compare April 22, 2025 15:23
@graphite-app graphite-app bot changed the base branch from graphite-base/10538 to main April 22, 2025 15:24
@Dunqing @overlookmotel
test(transformer/class-properties): overrides a few tests that contai…
e77b382 
…n class properties without initializer usages
@graphite-app graphite-app bot force-pushed the 04-22-test_transformer_class-properties_overrides_a_few_tests_that_contain_class_properties_without_initializer_usages branch from edb1aa9 to e77b382 Compare April 22, 2025 15:24
graphite-app bot pushed a commit that referenced this pull request Apr 23, 2025
@Dunqing
feat(tasks/transforme_conformance): support --override for tests ha…
2eb1f88 
…ve been passed (#10536)

Before, we could only override the failed tests, now we support `--override` for the passed tests. This is useful for fixing the Babel itself bugs/misalignments. See #10538 and #10491
@Dunqing
Copy link
Member Author

Dunqing commented Apr 25, 2025

#10491 has closed, no longer need to override tests

@Dunqing Dunqing closed this Apr 25, 2025
@Boshen Boshen deleted the 04-22-test_transformer_class-properties_overrides_a_few_tests_that_contain_class_properties_without_initializer_usages branch August 30, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Dunqing