Skip to content

Comments

feat(ecmascript): add unknown_global_side_effects to MayHaveSideEffectsContext#10130

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-30-feat_ecmascript_add_unknown_global_side_effects_to_mayhavesideeffectscontext_
Mar 31, 2025
Merged

feat(ecmascript): add unknown_global_side_effects to MayHaveSideEffectsContext#10130
graphite-app[bot] merged 1 commit intomainfrom
03-30-feat_ecmascript_add_unknown_global_side_effects_to_mayhavesideeffectscontext_

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Mar 30, 2025 •
edited
Loading

This was referenced Mar 30, 2025
Merged
Merged
Merged
@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Mar 30, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red mentioned this pull request Mar 30, 2025
Merged
@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Mar 30, 2025
@sapphi-red sapphi-red marked this pull request as ready for review March 30, 2025 10:45
@sapphi-red sapphi-red force-pushed the 03-30-feat_ecmascript_add_unknown_global_side_effects_to_mayhavesideeffectscontext_ branch from b2fdf36 to 974d5bc Compare March 30, 2025 10:49
@sapphi-red sapphi-red force-pushed the 03-30-feat_ecmascript_add_property_read_side_effects_to_mayhavesideeffectscontext_ branch from 2c586f7 to ce73ad3 Compare March 30, 2025 10:49
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 30, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10130 will create unknown performance changes

Comparing 03-30-feat_ecmascript_add_unknown_global_side_effects_to_mayhavesideeffectscontext_ (11ddda6) with main (ef3451c)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.6 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.7 ms N/A
🆕 formatter[antd.js] N/A 7.6 ms N/A
🆕 formatter[react.development.js] N/A 43.8 µs N/A
🆕 formatter[typescript.js] N/A 7.4 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.2 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.8 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A
🆕 mangler[antd.js] N/A 16 ms N/A
🆕 mangler[react.development.js] N/A 293.8 µs N/A
🆕 mangler[typescript.js] N/A 39.7 ms N/A
🆕 minifier[antd.js] N/A 165.6 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 291.6 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 30, 2025
@Boshen Graphite App
Copy link
Member

Boshen commented Mar 30, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 30, 7:53 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 31, 2:53 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 31, 3:27 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Mar 31, 3:35 AM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 03-30-feat_ecmascript_add_property_read_side_effects_to_mayhavesideeffectscontext_ branch 2 times, most recently from 45c3045 to b0e1322 Compare March 30, 2025 12:06
@graphite-app graphite-app bot force-pushed the 03-30-feat_ecmascript_add_unknown_global_side_effects_to_mayhavesideeffectscontext_ branch from 974d5bc to 6d8a10e Compare March 30, 2025 12:06
@Boshen Boshen added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Mar 31, 2025
@graphite-app graphite-app bot force-pushed the 03-30-feat_ecmascript_add_property_read_side_effects_to_mayhavesideeffectscontext_ branch from b0e1322 to ef3451c Compare March 31, 2025 07:26
@graphite-app graphite-app bot force-pushed the 03-30-feat_ecmascript_add_unknown_global_side_effects_to_mayhavesideeffectscontext_ branch from 6d8a10e to 11ddda6 Compare March 31, 2025 07:27
Base automatically changed from 03-30-feat_ecmascript_add_property_read_side_effects_to_mayhavesideeffectscontext_ to main March 31, 2025 07:32
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 31, 2025
@graphite-app graphite-app bot merged commit 11ddda6 into main Mar 31, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 03-30-feat_ecmascript_add_unknown_global_side_effects_to_mayhavesideeffectscontext_ branch March 31, 2025 07:35
@oxc-bot oxc-bot mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @Boshen