Skip to content

Comments

feat(semantic): check redeclaration of function declaration and class declaration#10093

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-28-feat_semantic_check_redeclaration_of_function_declaration_and_class_declaration
Mar 29, 2025
Merged

feat(semantic): check redeclaration of function declaration and class declaration#10093
graphite-app[bot] merged 1 commit intomainfrom
03-28-feat_semantic_check_redeclaration_of_function_declaration_and_class_declaration

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 28, 2025 •
edited
Loading

Preparing for #10094. This will lead to a duplicate error of redeclaration of function and class, but it will be removed in #10094.

This was referenced Mar 28, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Mar 28, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 28, 2025
Merged
Merged
Merged
@github-actions github-actions bot added A-semantic Area - Semantic C-enhancement Category - New feature or request labels Mar 28, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 28, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10093 will create unknown performance changes

Comparing 03-28-feat_semantic_check_redeclaration_of_function_declaration_and_class_declaration (9b92919) with 03-27-feat_semantic_add_symbol_id_for_declare_function_binding (84a3490)

Summary

🆕 33 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.7 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.6 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.5 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.8 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A
🆕 mangler[antd.js] N/A 16 ms N/A
🆕 mangler[react.development.js] N/A 294.8 µs N/A
🆕 mangler[typescript.js] N/A 39.7 ms N/A
🆕 minifier[antd.js] N/A 165.6 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 291.6 ms N/A
🆕 estree[checker.ts] N/A 96.9 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 92.3 µs N/A
🆕 parser[antd.js] N/A 113.2 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@graphite-app graphite-app bot force-pushed the 03-27-feat_semantic_add_symbol_id_for_declare_function_binding branch 2 times, most recently from 6e5fca2 to 268a827 Compare March 28, 2025 07:45
@graphite-app graphite-app bot force-pushed the 03-28-feat_semantic_check_redeclaration_of_function_declaration_and_class_declaration branch from 3a6265c to 30e4882 Compare March 28, 2025 07:45
@Dunqing Dunqing marked this pull request as ready for review March 28, 2025 07:45
@Dunqing Dunqing requested a review from Boshen as a code owner March 28, 2025 07:45
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 29, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 29, 2025 •
edited
Loading

Merge activity

@Dunqing
feat(semantic): check redeclaration of function declaration and class…
9b92919 
… declaration (#10093)

Preparing for #10094. This will lead to a duplicate error of redeclaration of function and class, but it will be removed in #10094.
@graphite-app graphite-app bot force-pushed the 03-27-feat_semantic_add_symbol_id_for_declare_function_binding branch from 268a827 to 84a3490 Compare March 29, 2025 14:15
@graphite-app graphite-app bot force-pushed the 03-28-feat_semantic_check_redeclaration_of_function_declaration_and_class_declaration branch from 30e4882 to 9b92919 Compare March 29, 2025 14:15
Base automatically changed from 03-27-feat_semantic_add_symbol_id_for_declare_function_binding to main March 29, 2025 14:26
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 29, 2025
@graphite-app graphite-app bot merged commit 9b92919 into main Mar 29, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 03-28-feat_semantic_check_redeclaration_of_function_declaration_and_class_declaration branch March 29, 2025 14:28
@oxc-bot oxc-bot mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Awaiting requested review from Boshen

Assignees

No one assigned

Labels

A-semantic Area - Semantic C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Dunqing