Skip to content

Comments

fix(linter): enable multi-file analysis for nested configs#10089

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-27-fix_linter_enable_multi-file_analysis_for_nested_configs
Mar 28, 2025
Merged

fix(linter): enable multi-file analysis for nested configs#10089
graphite-app[bot] merged 1 commit intomainfrom
03-27-fix_linter_enable_multi-file_analysis_for_nested_configs

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Mar 28, 2025

previously, multi-file analysis was only enabled when the root .oxlintrc.json contained the import plugin. now, we enable if any .oxlintrc.json has the import plugin.

Copy link
Member Author

camchenry commented Mar 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-cli Area - CLI C-bug Category - Bug labels Mar 28, 2025
@camchenry camchenry marked this pull request as ready for review March 28, 2025 03:07
@camchenry camchenry requested a review from Sysix March 28, 2025 03:14
@camchenry camchenry force-pushed the 03-27-fix_linter_enable_multi-file_analysis_for_nested_configs branch from 0a77be3 to 4d973b9 Compare March 28, 2025 04:17
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025
Copy link
Member

Boshen commented Mar 28, 2025

Merge activity

  • Mar 28, 12:37 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 28, 12:37 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Mar 28, 5:49 AM UTC: The Graphite merge queue couldn't merge this PR because it timed out.
  • Mar 28, 2:49 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 28, 2:49 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Mar 28, 2:50 AM EDT: A user merged this pull request with the Graphite merge queue.

graphite-app bot pushed a commit that referenced this pull request Mar 28, 2025
- fixes #10054

previously, multi-file analysis was only enabled when the root `.oxlintrc.json` contained the import plugin. now, we enable if any `.oxlintrc.json` has the import plugin.
@graphite-app graphite-app bot force-pushed the 03-27-fix_linter_enable_multi-file_analysis_for_nested_configs branch from 4d973b9 to 6e916c9 Compare March 28, 2025 05:29
- fixes #10054

previously, multi-file analysis was only enabled when the root `.oxlintrc.json` contained the import plugin. now, we enable if any `.oxlintrc.json` has the import plugin.
@graphite-app graphite-app bot force-pushed the 03-27-fix_linter_enable_multi-file_analysis_for_nested_configs branch from 6e916c9 to 2c80858 Compare March 28, 2025 05:49
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025
@graphite-app graphite-app bot merged commit 2c80858 into main Mar 28, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 03-27-fix_linter_enable_multi-file_analysis_for_nested_configs branch March 28, 2025 06:50
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025
Boshen added a commit that referenced this pull request Apr 1, 2025
## [0.16.4] - 2025-04-01

- da6336c language_server: [**BREAKING**] Remove `enable` configuration,
the client should shutdown the server instead (#9990) (Sysix)

### Features

- 06e3db9 linter: Support `multipleFileExtensions` option for
`unicorn/filename-case` (#10118) (shulaoda)
- dbe0e46 linter: Support `ignore` option for `unicorn/filename-case`
(#10107) (shulaoda)

### Bug Fixes

- 0a33e27 editor: Update `initializationOptions` for a possible restart
(#10121) (Sysix)
- ac780a2 editor: Repair filewatchers when no custom config provided
(#10104) (Sysix)
- 4303ace editor: Dont send `didChangeConfiguration` request to the
server when it is shutdown (#10084) (Sysix)
- 07f2a25 editor: Enable regex parsing in language server (#10035)
(camchenry)
- fcf7702 language_server: Start from a default oxlint configuration +
SafeFix for nested configuration (#10043) (Sysix)
- aba3654 linter: Span disable directive correctly on next line (#10141)
(Ulrich Stark 🦀)
- 2c80858 linter: Enable multi-file analysis for nested configs (#10089)
(camchenry)

### Performance

- 566be59 linter: Replace `phf_set` with `array` in `eslint/func-names`
(#10119) (shulaoda)
- 5e14fe9 linter: Inline `PRE_DEFINE_VAR` and use `array` format
(#10079) (shulaoda)

### Refactor

- 327be53 editor: `LanguageClient` can be undefined (#10112) (Sysix)
- 5ec477c editor: Make `onConfigChange` async (#10110) (Sysix)
- a278d73 editor: Use warning background when the plugin is deactived
(#10085) (Sysix)
- c0e5251 language_server: Set `null` as a default value for
`configPath` (#10047) (Sysix)
- 09c0ac6 linter: Improve `unicorn/filename-case` (#10117) (shulaoda)
- d8e49a1 linter: Compute lintable extensions at compile time (#10090)
(camchenry)
- b3ec235 linter: Use items of `oxc_ast::ast` module directly (#10100)
(Ulrich Stark 🦀)
- 93e6c0b linter: Use `FormalParameter::has_modifier` to detect
parameter properties (#10097) (Ulrich Stark 🦀)
- 5d829c2 semantic: Align handling of declaring symbol for function with
TypeScript (#10086) (Dunqing)

### Testing

- 410b8d6 editor: Use debug build of the language server (#10083)
(Sysix)
- 500add0 editor: Add test for `oxc.fixAll` command (#10045) (Sysix)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: import/no-cycle rule diagnostic not emitted with nested configurations

2 participants