Skip to content

Comments

feat(semantic/scoping): add declaration and flags fields for Redeclaraion#10060

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-26-feat_semantic_scoping_add_declaration_and_flags_fields_for_symbol_declarations
Mar 28, 2025
Merged

feat(semantic/scoping): add declaration and flags fields for Redeclaraion#10060
graphite-app[bot] merged 1 commit intomainfrom
03-26-feat_semantic_scoping_add_declaration_and_flags_fields_for_symbol_declarations

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 26, 2025 •
edited
Loading

declaration and flags are also fields of the symbol. Before, we only had a span info in symbol_redeclarations, which means we have no way to know what the redeclaration AST node is and what the symbol flags is

@Dunqing Dunqing mentioned this pull request Mar 26, 2025
Merged
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Mar 26, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Mar 26, 2025
Merged
@github-actions github-actions bot added A-semantic Area - Semantic C-enhancement Category - New feature or request labels Mar 26, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 26, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10060 will create unknown performance changes

Comparing 03-26-feat_semantic_scoping_add_declaration_and_flags_fields_for_symbol_declarations (528469e) with main (84e167e)

Summary

🆕 32 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.6 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.6 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.2 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.8 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 mangler[antd.js] N/A 16 ms N/A
🆕 mangler[react.development.js] N/A 293.8 µs N/A
🆕 mangler[typescript.js] N/A 39.7 ms N/A
🆕 minifier[antd.js] N/A 165.6 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 291.6 ms N/A
🆕 estree[checker.ts] N/A 96.1 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 92.3 µs N/A
🆕 parser[antd.js] N/A 113.5 ms N/A
🆕 parser[cal.com.tsx] N/A 30.1 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Dunqing Dunqing force-pushed the 03-26-feat_semantic_introduce_redeclaraion_for_symbol_declarations branch from 2df4aa0 to ceebcc0 Compare March 26, 2025 08:47
@Dunqing Dunqing force-pushed the 03-26-feat_semantic_scoping_add_declaration_and_flags_fields_for_symbol_declarations branch from ac9d13f to 18689d0 Compare March 26, 2025 08:47
This was referenced Mar 26, 2025
Merged
Merged
Merged
Merged
@Dunqing Dunqing marked this pull request as ready for review March 27, 2025 12:51
@Dunqing Dunqing requested a review from Boshen as a code owner March 27, 2025 12:51
@Dunqing Dunqing mentioned this pull request Mar 28, 2025
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 28, 2025 •
edited
Loading

Merge activity

@Dunqing
feat(semantic/scoping): add declaration and flags fields for Rede…
528469e 
…claraion (#10060)

`declaration` and `flags` are also fields of the symbol. Before, we only had a span info in `symbol_redeclarations`, which means we have no way to know what the redeclaration AST node is and what the symbol flags is
@graphite-app graphite-app bot force-pushed the 03-26-feat_semantic_introduce_redeclaraion_for_symbol_declarations branch from ceebcc0 to b804f7c Compare March 28, 2025 04:12
@graphite-app graphite-app bot requested a review from overlookmotel as a code owner March 28, 2025 04:12
@graphite-app graphite-app bot force-pushed the 03-26-feat_semantic_scoping_add_declaration_and_flags_fields_for_symbol_declarations branch from 18689d0 to 528469e Compare March 28, 2025 04:13
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025
Base automatically changed from 03-26-feat_semantic_introduce_redeclaraion_for_symbol_declarations to main March 28, 2025 04:20
@graphite-app graphite-app bot merged commit 528469e into main Mar 28, 2025
24 of 25 checks passed
@graphite-app graphite-app bot deleted the 03-26-feat_semantic_scoping_add_declaration_and_flags_fields_for_symbol_declarations branch March 28, 2025 04:25
This was referenced Mar 28, 2025
Merged
Merged
Merged
@oxc-bot oxc-bot mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Awaiting requested review from Boshen

@overlookmotel overlookmotel Awaiting requested review from overlookmotel

Assignees

No one assigned

Labels

A-semantic Area - Semantic C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Dunqing