Skip to content

formatter: oxfmt 0.57.0 SCSS comments stripped regressions #24193

Description

@KieranP

Latest oxfmt release switched CSS parser, has issue with SCSS style comments (SCSS allows comment using // which are stipped from final output, compared with /* */ which is preserved in final output.

Input

@use 'bootstrap/scss/bootstrap.scss' with (
  // Colors
  $primary: variables.$primary,
  $secondary: variables.$secondary,
  $success: variables.$success,
  $warning: variables.$warning,
  $danger: variables.$danger,
  $info: variables.$info,
  $dark: variables.$dark,
  $light: variables.$light,

  // Components
  $box-shadow: variables.$box-shadow,

  // Spacing
  $spacer: variables.$spacer,

  // Tooltips
  $tooltip-font-size: variables.$tooltip-font-size
);

Config

{}

Oxfmt output

Oxfmt version: 0.57.0

@use 'bootstrap/scss/bootstrap.scss' with (
  $primary: variables.$primary,
  $secondary: variables.$secondary,
  $success: variables.$success,
  $warning: variables.$warning,
  $danger: variables.$danger,
  $info: variables.$info,
  $dark: variables.$dark,
  $light: variables.$light,
  $box-shadow: variables.$box-shadow,
  $spacer: variables.$spacer,
  $tooltip-font-size: variables.$tooltip-font-size
);

(comments stripped)

Oxfmt playground link

No response

Prettier output

Comments preserved:

@use 'bootstrap/scss/bootstrap.scss' with (
  // Colors
  $primary: variables.$primary,
  $secondary: variables.$secondary,
  $success: variables.$success,
  $warning: variables.$warning,
  $danger: variables.$danger,
  $info: variables.$info,
  $dark: variables.$dark,
  $light: variables.$light,

  // Components
  $box-shadow: variables.$box-shadow,

  // Spacing
  $spacer: variables.$spacer,

  // Tooltips
  $tooltip-font-size: variables.$tooltip-font-size
);

Prettier playground link

No response

Additional notes

No response

Metadata

Metadata

Assignees

Labels

A-formatter-prettier-diffArea - Formatter difference with PrettierF-lang-cssFormatter - oxc_formatter_css related

Type

Fields

Priority

None yet

Effort

None yet

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions