Skip to content

formatter: Diff with Prettier on destructured array parameters with inline comment #20962

Description

@egilsster

Input

const foo = {
  createNewConnection: ([
    password,
    ,
    // @ts-expect-error incomplete type
    username,

  ]) => {
    void password;
    void username;
  },
}

Config

{}

Oxfmt output

Oxfmt version: latest

const foo = {
  createNewConnection: ([
    password,
    // @ts-expect-error incomplete type
    ,
    username,
  ]) => {
    void password;
    void username;
  },
};

Oxfmt playground link

https://playground.oxc.rs/?t=formatter&formatterPanels=output%2Cprettier&options=%7B%22run%22%3A%7B%22lint%22%3Atrue%2C%22formatter%22%3Atrue%2C%22transform%22%3Afalse%2C%22isolatedDeclarations%22%3Afalse%2C%22whitespace%22%3Afalse%2C%22mangle%22%3Afalse%2C%22compress%22%3Afalse%2C%22scope%22%3Atrue%2C%22symbol%22%3Atrue%2C%22cfg%22%3Afalse%7D%2C%22parser%22%3A%7B%22extension%22%3A%22tsx%22%2C%22allowReturnOutsideFunction%22%3Atrue%2C%22preserveParens%22%3Atrue%2C%22allowV8Intrinsics%22%3Atrue%2C%22semanticErrors%22%3Atrue%7D%2C%22linter%22%3A%7B%7D%2C%22formatter%22%3A%7B%22useTabs%22%3Afalse%2C%22tabWidth%22%3A2%2C%22endOfLine%22%3A%22lf%22%2C%22printWidth%22%3A80%2C%22singleQuote%22%3Afalse%2C%22jsxSingleQuote%22%3Afalse%2C%22quoteProps%22%3A%22as-needed%22%2C%22trailingComma%22%3A%22all%22%2C%22semi%22%3Atrue%2C%22arrowParens%22%3A%22always%22%2C%22bracketSpacing%22%3Atrue%2C%22bracketSameLine%22%3Afalse%2C%22objectWrap%22%3A%22preserve%22%2C%22singleAttributePerLine%22%3Afalse%7D%2C%22transformer%22%3A%7B%22target%22%3A%22es2015%22%2C%22useDefineForClassFields%22%3Atrue%2C%22experimentalDecorators%22%3Atrue%2C%22emitDecoratorMetadata%22%3Atrue%7D%2C%22isolatedDeclarations%22%3A%7B%22stripInternal%22%3Afalse%7D%2C%22codegen%22%3A%7B%22normal%22%3Atrue%2C%22jsdoc%22%3Atrue%2C%22annotation%22%3Atrue%2C%22legal%22%3Atrue%7D%2C%22compress%22%3A%7B%7D%2C%22mangle%22%3A%7B%22topLevel%22%3Atrue%2C%22keepNames%22%3Afalse%7D%2C%22controlFlow%22%3A%7B%22verbose%22%3Afalse%7D%2C%22inject%22%3A%7B%22inject%22%3A%7B%7D%7D%2C%22define%22%3A%7B%22define%22%3A%7B%7D%7D%7D&code=const%20foo%20%3D%20%7B%0A%20%20createNewConnection%3A%20(%5B%0A%20%20%20%20password%2C%0A%20%20%20%20%2C%0A%20%20%20%20%2F%2F%20%40ts-expect-error%20incomplete%20type%0A%20%20%20%20username%2C%0A%0A%20%20%5D)%20%3D%3E%20%7B%0A%20%20%20%20void%20password%3B%0A%20%20%20%20void%20username%3B%0A%20%20%7D%2C%0A%7D

Prettier output

Prettier version: 3.8.1

const foo = {
  createNewConnection: ([
    password,
    ,
    // @ts-expect-error incomplete type
    username,
  ]) => {
    void password;
    void username;
  },
};

Prettier playground link

No response

Additional notes

The ts suppression gets moved and thus resulting in it not applying to the correct line

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Fields

    Priority

    None yet

    Effort

    None yet

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions