Skip to content

linter: jsdoc/empty-tags rule has incorrect logic/test #16871

@connorshea

Description

@connorshea

What version of Oxlint are you using?

N/A

What command did you run?

N/A

What does your .oxlintrc.json config file look like?

N/A

What happened?

This test is not testing what it should be:

Some(serde_json::json!({
"jsdoc": {
"ignorePrivate": true,
},
})),

The settings blob has no "settings" key, and so does ignorePrivate does not get set in the settings. The test therefore falls back to the default value of false. If I try to fix this, the test fails, so I think the implementation may have a bug?

You can see the original implementation of this test here: https://github.com/gajus/eslint-plugin-jsdoc/blob/81cdb0a160db46848eb301955b1673b98d15f7df/test/rules/assertions/emptyTags.js#L189-L217

I think ignorePrivate should not be considered when checking this rule:
https://github.com/gajus/eslint-plugin-jsdoc/blob/81cdb0a160db46848eb301955b1673b98d15f7df/docs/rules/empty-tags.md?plain=1#L31-L33

Metadata

Metadata

Assignees

Labels

Type

Priority

None yet

Effort

None yet

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions