fix(estree/tokens): reverse field order of regex object in tokens (#19679)

overlookmotel · overlookmotel · commit f5694ced32b6 · 2026-02-24T16:04:11.000Z
Our convention is that object properties are in source code order. Reverse `pattern` and `flags` properties of `regex` objects in ESTree tokens to align with this pattern. Bump `estree-conformance` submodule to include oxc-project/estree-conformance#182 which makes the same change in snapshots for conformance tests.
diff --git a/.github/scripts/clone-parallel.mjs b/.github/scripts/clone-parallel.mjs
@@ -15,7 +15,7 @@ const TEST262_SHA = "3aa9cb2c71afc21aefc1f82e899af1d0403351ba";
 const BABEL_SHA = "308c8d85b2c81f825f630f765387a135fbf066d9";
 const TYPESCRIPT_SHA = "347254895823a36a1b1b1c80471422da54ad77de";
 const PRETTIER_SHA = "812a4d0071270f61a7aa549d625b618be7e09d71";
-const ESTREE_CONFORMANCE_SHA = "eeda64c238d88512d0bf40dd7e85a08a08af26dc";
+const ESTREE_CONFORMANCE_SHA = "57b0d682b191655b68513165079080943eb279d4";
 const NODE_COMPAT_TABLE_SHA = "499beb6f1daa36f10c26b85a7f3ec3b3448ded23";
 
 const repoRoot = join(import.meta.dirname, "..", "..");
diff --git a/apps/oxlint/test/fixtures/tokens/output.snap.md b/apps/oxlint/test/fixtures/tokens/output.snap.md
@@ -507,7 +507,7 @@
    `----
 
   x tokens-plugin(tokens): RegularExpression ("/abc/gu")
-  |   regex: {"flags":"gu","pattern":"abc"}
+  |   regex: {"pattern":"abc","flags":"gu"}
    ,-[files/index.js:6:9]
  5 | // Another comment
  6 | let y = /abc/gu;
diff --git a/crates/oxc_estree_tokens/src/lib.rs b/crates/oxc_estree_tokens/src/lib.rs
@@ -27,8 +27,8 @@ pub struct EstreeToken<'a> {
 
 #[derive(Serialize)]
 pub struct EstreeRegExpToken<'a> {
-    pub flags: &'a str,
     pub pattern: &'a str,
+    pub flags: &'a str,
 }
 
 #[derive(Debug, Clone, Copy)]
@@ -170,7 +170,7 @@ fn to_estree_tokens<'a>(
             source_value
         };
         let regex = if kind == Kind::RegExp {
-            regex_parts(source_value).map(|(pattern, flags)| EstreeRegExpToken { flags, pattern })
+            regex_parts(source_value).map(|(pattern, flags)| EstreeRegExpToken { pattern, flags })
         } else {
             None
         };
diff --git a/tasks/coverage/snapshots/estree_acorn_jsx.snap b/tasks/coverage/snapshots/estree_acorn_jsx.snap
@@ -1,4 +1,4 @@
-commit: eeda64c2
+commit: 57b0d682
 
 estree_acorn_jsx Summary:
 AST Parsed     : 39/39 (100.00%)
diff --git a/tasks/coverage/snapshots/estree_acorn_jsx_tokens.snap b/tasks/coverage/snapshots/estree_acorn_jsx_tokens.snap
@@ -1,4 +1,4 @@
-commit: eeda64c2
+commit: 57b0d682
 
 estree_acorn_jsx_tokens Summary:
 AST Parsed     : 39/39 (100.00%)

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-commit: eeda64c2`
	`1`	`+commit: 57b0d682`
`2`	`2`
`3`	`3`	`estree_acorn_jsx Summary:`
`4`	`4`	`AST Parsed : 39/39 (100.00%)`