Ensure that no unknown fields are allowed in OxlintOverride struct.

connorshea · connorshea · commit b2273d747164 · 2025-12-14T22:31:04.000-07:00
Add test to validate that this fails when there is an unknown field in an override config.
diff --git a/crates/oxc_linter/src/config/overrides.rs b/crates/oxc_linter/src/config/overrides.rs
@@ -76,6 +76,7 @@ impl JsonSchema for OxlintOverrides {
 
 #[derive(Debug, Default, Clone, Deserialize, Serialize, JsonSchema)]
 #[non_exhaustive]
+#[serde(deny_unknown_fields)]
 pub struct OxlintOverride {
     /// A list of glob patterns to override.
     ///
diff --git a/crates/oxc_linter/src/snapshots/schema_json.snap b/crates/oxc_linter/src/snapshots/schema_json.snap
@@ -509,7 +509,8 @@ expression: json
             }
           ]
         }
-      }
+      },
+      "additionalProperties": false
     },
     "OxlintOverrides": {
       "type": "array",
diff --git a/npm/oxlint/configuration_schema.json b/npm/oxlint/configuration_schema.json
@@ -505,7 +505,8 @@
             }
           ]
         }
-      }
+      },
+      "additionalProperties": false
     },
     "OxlintOverrides": {
       "type": "array",
@@ -660,4 +661,4 @@
     }
   },
   "markdownDescription": "Oxlint Configuration File\n\nThis configuration is aligned with ESLint v8's configuration schema (`eslintrc.json`).\n\nUsage: `oxlint -c oxlintrc.json --import-plugin`\n\n::: danger NOTE\n\nOnly the `.json` format is supported. You can use comments in configuration files.\n\n:::\n\nExample\n\n`.oxlintrc.json`\n\n```json\n{\n\"$schema\": \"./node_modules/oxlint/configuration_schema.json\",\n\"plugins\": [\"import\", \"typescript\", \"unicorn\"],\n\"env\": {\n\"browser\": true\n},\n\"globals\": {\n\"foo\": \"readonly\"\n},\n\"settings\": {\n},\n\"rules\": {\n\"eqeqeq\": \"warn\",\n\"import/no-cycle\": \"error\",\n\"react/self-closing-comp\": [\"error\", { \"html\": false }]\n},\n\"overrides\": [\n{\n\"files\": [\"*.test.ts\", \"*.spec.ts\"],\n\"rules\": {\n\"@typescript-eslint/no-explicit-any\": \"off\"\n}\n}\n]\n}\n```"
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -509,7 +509,8 @@ expression: json`
`509`	`509`	`}`
`510`	`510`	`]`
`511`	`511`	`}`
`512`		`- }`
	`512`	`+ },`
	`513`	`+ "additionalProperties": false`
`513`	`514`	`},`
`514`	`515`	`"OxlintOverrides": {`
`515`	`516`	`"type": "array",`
Original file line number	Diff line number	Diff line change
`@@ -505,7 +505,8 @@`
`505`	`505`	`}`
`506`	`506`	`]`
`507`	`507`	`}`
`508`		`- }`
	`508`	`+ },`
	`509`	`+ "additionalProperties": false`
`509`	`510`	`},`
`510`	`511`	`"OxlintOverrides": {`
`511`	`512`	`"type": "array",`
`@@ -660,4 +661,4 @@`
`660`	`661`	`}`
`661`	`662`	`},`
`662`	`663`	"markdownDescription": "Oxlint Configuration File\n\nThis configuration is aligned with ESLint v8's configuration schema (`eslintrc.json`).\n\nUsage: `oxlint -c oxlintrc.json --import-plugin`\n\n::: danger NOTE\n\nOnly the `.json` format is supported. You can use comments in configuration files.\n\n:::\n\nExample\n\n`.oxlintrc.json`\n\n```json\n{\n\"$schema\": \"./node_modules/oxlint/configuration_schema.json\",\n\"plugins\": [\"import\", \"typescript\", \"unicorn\"],\n\"env\": {\n\"browser\": true\n},\n\"globals\": {\n\"foo\": \"readonly\"\n},\n\"settings\": {\n},\n\"rules\": {\n\"eqeqeq\": \"warn\",\n\"import/no-cycle\": \"error\",\n\"react/self-closing-comp\": [\"error\", { \"html\": false }]\n},\n\"overrides\": [\n{\n\"files\": [\".test.ts\", \".spec.ts\"],\n\"rules\": {\n\"@typescript-eslint/no-explicit-any\": \"off\"\n}\n}\n]\n}\n```"
`663`		`-}`
	`664`	`+}`