refactor(linter): use to_string instead of into (#12147)

overlookmotel · overlookmotel · commit 532b8166a2e2 · 2025-07-09T09:24:30.000Z
Follow-on after #11980. Pure refactor, and this is a matter of personal preference. Personally, I find `.into()` confusing as it's not clear "into what?". I find more explicit code like `.to_string()` clearer.
diff --git a/crates/oxc_linter/src/config/config_builder.rs b/crates/oxc_linter/src/config/config_builder.rs
@@ -414,7 +414,7 @@ impl ConfigStoreBuilder {
 
         let resolved = resolver.resolve(oxlintrc_dir_path, plugin_name).map_err(|e| {
             ConfigBuilderError::PluginLoadFailed {
-                plugin_name: plugin_name.into(),
+                plugin_name: plugin_name.to_string(),
                 error: e.to_string(),
             }
         })?;
@@ -425,14 +425,14 @@ impl ConfigStoreBuilder {
             tokio::runtime::Handle::current().block_on((external_linter.load_plugin)(plugin_path))
         })
         .map_err(|e| ConfigBuilderError::PluginLoadFailed {
-            plugin_name: plugin_name.into(),
+            plugin_name: plugin_name.to_string(),
             error: e.to_string(),
         })?;
 
         match result {
             PluginLoadResult::Success => Ok(()),
             PluginLoadResult::Failure(e) => Err(ConfigBuilderError::PluginLoadFailed {
-                plugin_name: plugin_name.into(),
+                plugin_name: plugin_name.to_string(),
                 error: e,
             }),
         }
