refactor(formatter): remove useless space()

Dunqing · Dunqing · commit 2ccd1d4ca5fa · 2025-12-15T16:35:21.000+08:00
diff --git a/crates/oxc_formatter/src/utils/assignment_like.rs b/crates/oxc_formatter/src/utils/assignment_like.rs
@@ -322,11 +322,11 @@ impl<'a> AssignmentLike<'a, '_> {
             }
             Self::ObjectProperty(property) => {
                 debug_assert!(!property.shorthand);
-                write!(f, [":", space()]);
+                write!(f, [":"]);
             }
             Self::BindingProperty(property) => {
                 if !property.shorthand {
-                    write!(f, [":", space()]);
+                    write!(f, [":"]);
                 }
             }
             Self::PropertyDefinition(property_class_member) => {
@@ -342,14 +342,11 @@ impl<'a> AssignmentLike<'a, '_> {
     fn write_right(&self, f: &mut Formatter<'_, 'a>, layout: AssignmentLikeLayout) {
         match self {
             Self::VariableDeclarator(declarator) => {
-                write!(
-                    f,
-                    [space(), with_assignment_layout(declarator.init().unwrap(), Some(layout))]
-                );
+                write!(f, [with_assignment_layout(declarator.init().unwrap(), Some(layout))]);
             }
             Self::AssignmentExpression(assignment) => {
                 let right = assignment.right();
-                write!(f, [space(), with_assignment_layout(right, Some(layout))]);
+                write!(f, [with_assignment_layout(right, Some(layout))]);
             }
             Self::ObjectProperty(property) => {
                 let value = property.value();
@@ -359,17 +356,14 @@ impl<'a> AssignmentLike<'a, '_> {
                 write!(f, property.value());
             }
             Self::PropertyDefinition(property) => {
-                write!(
-                    f,
-                    [space(), with_assignment_layout(property.value().unwrap(), Some(layout))]
-                );
+                write!(f, [with_assignment_layout(property.value().unwrap(), Some(layout))]);
             }
             Self::TSTypeAliasDeclaration(declaration) => {
                 if let AstNodes::TSUnionType(union) = declaration.type_annotation().as_ast_nodes() {
                     union.write(f);
                     union.format_trailing_comments(f);
                 } else {
-                    write!(f, [space(), declaration.type_annotation()]);
+                    write!(f, [declaration.type_annotation()]);
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -322,11 +322,11 @@ impl<'a> AssignmentLike<'a, '_> {`
`322`	`322`	`}`
`323`	`323`	`Self::ObjectProperty(property) => {`
`324`	`324`	`debug_assert!(!property.shorthand);`
`325`		`- write!(f, [":", space()]);`
	`325`	`+ write!(f, [":"]);`
`326`	`326`	`}`
`327`	`327`	`Self::BindingProperty(property) => {`
`328`	`328`	`if !property.shorthand {`
`329`		`- write!(f, [":", space()]);`
	`329`	`+ write!(f, [":"]);`
`330`	`330`	`}`
`331`	`331`	`}`
`332`	`332`	`Self::PropertyDefinition(property_class_member) => {`
`@@ -342,14 +342,11 @@ impl<'a> AssignmentLike<'a, '_> {`
`342`	`342`	`fn write_right(&self, f: &mut Formatter<'_, 'a>, layout: AssignmentLikeLayout) {`
`343`	`343`	`match self {`
`344`	`344`	`Self::VariableDeclarator(declarator) => {`
`345`		`- write!(`
`346`		`- f,`
`347`		`- [space(), with_assignment_layout(declarator.init().unwrap(), Some(layout))]`
`348`		`- );`
	`345`	`+ write!(f, [with_assignment_layout(declarator.init().unwrap(), Some(layout))]);`
`349`	`346`	`}`
`350`	`347`	`Self::AssignmentExpression(assignment) => {`
`351`	`348`	`let right = assignment.right();`
`352`		`- write!(f, [space(), with_assignment_layout(right, Some(layout))]);`
	`349`	`+ write!(f, [with_assignment_layout(right, Some(layout))]);`
`353`	`350`	`}`
`354`	`351`	`Self::ObjectProperty(property) => {`
`355`	`352`	`let value = property.value();`
`@@ -359,17 +356,14 @@ impl<'a> AssignmentLike<'a, '_> {`
`359`	`356`	`write!(f, property.value());`
`360`	`357`	`}`
`361`	`358`	`Self::PropertyDefinition(property) => {`
`362`		`- write!(`
`363`		`- f,`
`364`		`- [space(), with_assignment_layout(property.value().unwrap(), Some(layout))]`
`365`		`- );`
	`359`	`+ write!(f, [with_assignment_layout(property.value().unwrap(), Some(layout))]);`
`366`	`360`	`}`
`367`	`361`	`Self::TSTypeAliasDeclaration(declaration) => {`
`368`	`362`	`if let AstNodes::TSUnionType(union) = declaration.type_annotation().as_ast_nodes() {`
`369`	`363`	`union.write(f);`
`370`	`364`	`union.format_trailing_comments(f);`
`371`	`365`	`} else {`
`372`		`- write!(f, [space(), declaration.type_annotation()]);`
	`366`	`+ write!(f, [declaration.type_annotation()]);`
`373`	`367`	`}`
`374`	`368`	`}`
`375`	`369`	`}`