fix(parser): update error code for type annotation in for...in statement (#19882)

camc314 · camc314 · commit 017de5d8279a · 2026-03-01T15:03:25.000Z
diff --git a/crates/oxc_semantic/src/diagnostics.rs b/crates/oxc_semantic/src/diagnostics.rs
@@ -425,11 +425,12 @@ pub fn accessor_without_body(span: Span) -> OxcDiagnostic {
 }
 
 /// The left-hand side of a 'for...of' statement cannot use a type annotation. (2483)
+/// The left-hand side of a 'for...in' statement cannot use a type annotation. (2404)
 #[cold]
 pub fn type_annotation_in_for_left(span: Span, is_for_in: bool) -> OxcDiagnostic {
-    let for_of_or_in = if is_for_in { "for...in" } else { "for...of" };
+    let (for_of_or_in, code) = if is_for_in { ("for...in", "2404") } else { ("for...of", "2483") };
     ts_error(
-        "2483",
+        code,
         format!(
             "The left-hand side of a '{for_of_or_in}' statement cannot use a type annotation.",
         ),
diff --git a/tasks/coverage/snapshots/parser_typescript.snap b/tasks/coverage/snapshots/parser_typescript.snap
@@ -6600,7 +6600,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
  30 │ }
     ╰────
 
-  × TS(2483): The left-hand side of a 'for...in' statement cannot use a type annotation.
+  × TS(2404): The left-hand side of a 'for...in' statement cannot use a type annotation.
    ╭─[typescript/tests/cases/compiler/forIn.ts:2:10]
  1 │ var arr = null;
  2 │ for (var i:number in arr) { // error
@@ -6609,7 +6609,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
    ╰────
   help: This iterator's type will be inferred from the iterable. You can safely remove the type annotation.
 
-  × TS(2483): The left-hand side of a 'for...in' statement cannot use a type annotation.
+  × TS(2404): The left-hand side of a 'for...in' statement cannot use a type annotation.
    ╭─[typescript/tests/cases/compiler/forInStatement4.ts:2:10]
  1 │ var expr: any;
  2 │ for (var a: number in expr) {
@@ -24886,7 +24886,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
  2 │ }
    ╰────
 
-  × TS(2483): The left-hand side of a 'for...in' statement cannot use a type annotation.
+  × TS(2404): The left-hand side of a 'for...in' statement cannot use a type annotation.
    ╭─[typescript/tests/cases/conformance/parser/ecmascript5/Statements/parserForInStatement5.ts:1:10]
  1 │ for (var a: number in X) {
    ·          ─
@@ -24908,15 +24908,15 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
  2 │ }
    ╰────
 
-  × TS(2483): The left-hand side of a 'for...in' statement cannot use a type annotation.
+  × TS(2404): The left-hand side of a 'for...in' statement cannot use a type annotation.
    ╭─[typescript/tests/cases/conformance/parser/ecmascript5/Statements/parserForInStatement7.ts:1:10]
  1 │ for (var a: number = 1, b: string = "" in X) {
    ·          ─
  2 │ }
    ╰────
   help: This iterator's type will be inferred from the iterable. You can safely remove the type annotation.
 
-  × TS(2483): The left-hand side of a 'for...in' statement cannot use a type annotation.
+  × TS(2404): The left-hand side of a 'for...in' statement cannot use a type annotation.
    ╭─[typescript/tests/cases/conformance/parser/ecmascript5/Statements/parserForInStatement7.ts:1:25]
  1 │ for (var a: number = 1, b: string = "" in X) {
    ·                         ─
@@ -26462,7 +26462,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
  38 │ }
     ╰────
 
-  × TS(2483): The left-hand side of a 'for...in' statement cannot use a type annotation.
+  × TS(2404): The left-hand side of a 'for...in' statement cannot use a type annotation.
     ╭─[typescript/tests/cases/conformance/statements/for-inStatements/for-inStatementsInvalid.ts:10:10]
   9 │ 
  10 │ for (var idx : number in {}) { }
