feat: reserve exports/module names in the mangler runtime test#185
Merged
Conversation
Node's cjs-module-lexer detects a CommonJS module's named exports by
lexically scanning for `exports.<name> =` / `module.exports` patterns.
UMD / CommonJS wrappers bind these as function parameters, and mangling
renames them, erasing every named export the lexer can see —
`import { queue } from "async"` then fails the runtime test. Renaming is
ecosystem-standard (esbuild / terser / swc do the same), so oxc keeps
default behavior and provides `MangleOptions::reserved`
(oxc-project/oxc#24041, the terser `mangle.reserved` equivalent); pass
`["exports", "module"]` here since this suite imports prebuilt dists
directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node's cjs-module-lexer detects a CommonJS module's named exports by lexically scanning for
exports.<name> =/module.exportstoken patterns — no scope analysis. UMD / CommonJS wrappers bindexports/moduleas ordinary function parameters, and mangling renames them, erasing every named export the lexer can see:import { queue } from "async"fails the mangler runtime test (failing run).Renaming these is ecosystem-standard (esbuild / terser / swc all do it by default), so oxc keeps its default behavior and instead provides
MangleOptions::reserved— the tersermangle.reservedequivalent, added in oxc-project/oxc#24041. This suite imports prebuilt dists directly, so pass["exports", "module"].Depends on oxc-project/oxc#24041 (merged). The mangler job also needs oxc-project/oxc#24033 to pass its idempotency phase.