patch: return compiled AST by value (no JSON) at the compile_program entry point#21
Merged
Merged
Conversation
…entry point The oxc and swc front-ends were deserializing compile_program's JSON output straight back into a File in the same process. Change CompileResult::Success.ast to Option<File> and return it by value; both bindings use it directly, dropping the serialize→deserialize round-trip. Kept as ./patches/0001-*.patch and re-applied by `just patch` on every sync, since the codemod only rewrites Cargo.toml. CompileResult still derives Serialize, so the JS-shim path is unchanged. Verified: workspace compiles and e2e output is byte-identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returns the compiled AST by value instead of serializing to JSON at the
compile_programentry point.