fix: reverse order of regex fields in tokens#182
Merged
overlookmotel merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
overlookmotel
deleted the
om/02-24-fix_reverse_order_of_regex_fields_in_tokens
branch
graphite-app bot
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Feb 24, 2026
…19679) Our convention is that object properties are in source code order. Reverse `pattern` and `flags` properties of `regex` objects in ESTree tokens to align with this pattern. Bump `estree-conformance` submodule to include oxc-project/estree-conformance#182 which makes the same change in snapshots for conformance tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-order fields of
regexobject in tokens in snapshots sopatternis beforeflags. Our convention in Oxc is that object fields are in source order, so we'd like to reverse the fields from the order Espree and TS-ESLint have them in.We need the snapshots in this repo to have that same order, so conformance tests pass.
(2nd attempt after #179)