Skip to content

PostgreSQL Fix in db_setup.sh restarts postgresql daemon in any case #668

@DePierre

Description

@DePierre

The fix for postgresql SSL configuration in the file db_setup.sh restarts the daemon even in the case when the user said "no" to the fix:

$ ./scripts/db_setup.sh init 

------------------------- OWTF Database Helper Script -------------------------
                    Helps in creation of user and database                     
-------------------------------------------------------------------------------

[+] Ensure that you have required values in /root/.owtf/db.cfg

Press Enter to continue
n
CREATE ROLE
CREATE DATABASE
Having SSL=true in postgres config causes many errors (psycopg2 problem)
Remove SSL=true from the PostgreSQL config?[Y/n]n
Restarting the postgresql service

https://github.com/owtf/owtf/blob/develop/scripts/db_setup.sh#L33 does not check the user input before restarting the daemon.

I would expect the script to do nothing if I answer "no", especially since restarting the daemon takes quite some time.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions