forked from apple/foundationdb
-
Notifications
You must be signed in to change notification settings - Fork 6
Ow fork 7.2 7 #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Ow fork 7.2 7 #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… we need to throw that error to terminate the SS. (apple#9712)
* fix KeyRangeRef::isCovered() * reproduce bug * more unit test added * fmt
In FastTriggeredWatchesWorkload, if the randomized new value for the given `setKey` happens to be the same as the current value, the following will hold - `first` is true, and - `getDuration` is 0, and - assertion `lastReadVersion - ver >= SERVER_KNOBS->MAX_VERSIONS_IN_FLIGHT || lastReadVersion - ver < SERVER_KNOBS->VERSIONS_PER_SECOND * (25 + getDuration)` will fail To fix this, change the assertion to ``` assert(first || lastReadVersion - ver >= SERVER_KNOBS->MAX_VERSIONS_IN_FLIGHT || lastReadVersion - ver < SERVER_KNOBS->VERSIONS_PER_SECOND * (25 + getDuration)); ``` Test plan: Apply to the fix on top of the commit reported by Joshua test. Rerun the command to make sure it passes.
This reverts commit c2939ba.
Change `StringRef()` to `""_sr`. Co-authored-by: A.J. Beamon <[email protected]>
The ruby bindings are not currently installable. We can reproduce this
with a build from source:
```
foundationdb/tmp on main [$?] via △ v3.25.2
zsh ❯ gem install ./bindings/ruby/fdb-7.3.0.gem
ERROR: While executing gem ... (Gem::Package::PathError)
installing into parent path /Users/andrew/projects/foundationdb/LICENSE of /Users/andrew/.rbenv/versions/3.2.1/lib/ruby/gems/3.2.0/gems/fdb-7.3.0 is not allowed
```
The problem is that the gemspec is interpolating the source directory
into the `files` array - and while this allows the gem to build, it
prevents it from actually being installed.
To fix it, we borrow similar code from the python bindings to copy the
necessary files and license into the build directory before building the
gem. This allows the gem to be installed:
```
foundationdb/tmp on main [!?] via △ v3.25.2
zsh ❯ gem install ./bindings/ruby/fdb-7.3.0.gem
Successfully installed fdb-7.3.0
Parsing documentation for fdb-7.3.0
Installing ri documentation for fdb-7.3.0
Done installing documentation for fdb after 0 seconds
1 gem installed
```
While fixing the gem build, I noticed that the gem will not run on arm64 machines, like the new spiffy M1/M2 MacBooks. On a whim, I tried just removing that restriction... and it does seem to work: ``` foundationdb/bindings/ruby/lib on ahayworth/fix-ruby-binding-build [?] via 💎 v3.2.1 took 2s zsh ❯ pry [1] pry(main)> require 'fdb' => true [2] pry(main)> FDB.api_version 720 LoadError: FoundationDB API only supported on x86_64 (not arm64) from /Users/andrew/.rbenv/versions/3.2.1/lib/ruby/gems/3.2.0/gems/fdb-7.3.0/lib/fdbimpl.rb:40:in `<module:FDBC>' [3] pry(main)> ```
…ite, the simulator could kill too many machines
…elliteTLogReplicationFactor and satelliteTLogUsableDcs. Update trace event with more info about the updated policy.
… proxies when getting key server locations
cherrypick multiple fixes [release-7.2]
Add compaction related knobs.
…verdbinfo-update-7.2 [Release 7.2] updateDBInfo.trigger() should trigger a new round of DbInfo update
By setting the latest version to 7.2.6
…free capacity check (apple#9892) * Don't block the exclusion of stateless processes by the free capacity check * Fix syntax * Make use of precomputed exclude check * Format code * Only consider newly excluded processes * Format code and update comment * Don't stop iterating over all storage processes in exclusion check
* error logger * recovery mode
apple#9796) (apple#9861) * Fix finishedQueries metric, add metrics reporting in GetMappedRange test [release-7.1] (apple#9785) * Fix finishedQueries metric, add metrics reporting in GetMappedRange test * refactor to make format work * resolve comments * Fix more comments * Fix bugs and change running time of test * use double for options
It is not protocol compatible, revert it to avoid deployment issue. Will have a new PR to have the feature if moving forward.
…stead of bytelimit. (apple#9884)
# Conflicts: # fdbserver/KeyValueStoreRocksDB.actor.cpp # fdbserver/include/fdbserver/RocksDBCheckpointUtils.actor.h
foxyholic
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge 7.2.7 into ow-fork