fix(web-app-files): [OCISDEV-451] external share ID fallback #13253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fallback to original ID if decoding the external share ID fails.
There was a problem hiding this comment.
Pull Request Overview
This PR adds error handling for external share ID decoding failures by implementing a fallback mechanism that uses the original ID when base64 decoding fails.
- Wrapped
atob()call in try-catch block to handle decoding errors gracefully - Added test coverage for the fallback scenario with a non-base64-encoded ID
- Documented the bugfix in the changelog
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/web-app-files/src/components/SideBar/Shares/Collaborators/ListItem.vue | Added try-catch block around atob() to fallback to original ID on decoding failure |
| packages/web-app-files/tests/unit/components/SideBar/Shares/Collaborators/ListItem.spec.ts | Added test case verifying fallback behavior when decoding fails |
| changelog/unreleased/bugfix-external-share-id-fallback.md | Added changelog entry documenting the bugfix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/web-app-files/src/components/SideBar/Shares/Collaborators/ListItem.vue
Show resolved
Hide resolved
packages/web-app-files/src/components/SideBar/Shares/Collaborators/ListItem.vue
Show resolved
Hide resolved
|
mzner
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fallback to original ID if decoding the external share ID fails.
Motivation and Context
ID can be also a plain string instead of base64 encoded string.
How Has This Been Tested?
romanperekhod/ocis-ocm:devimage, create a federated share and open sharesTypes of changes