feat(web-app-admin-settings): [OCISDEV-348] use api groups search #13235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements server-side group search in the admin settings, replacing client-side filtering. When users search for groups, the search term is now sent directly to the API endpoint rather than filtering results in the browser.
Key changes:
- Search now uses the API's search parameter instead of client-side filtering
- Search term is stored in URL query parameters (
q_displayName) - Removed client-side filtering logic and associated footer text
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/web-app-admin-settings/src/views/Groups.vue |
Added search UI components and filterGroups function to handle API-based search |
packages/web-app-admin-settings/src/components/Groups/GroupsList.vue |
Removed client-side filtering logic, converted filter input to a slot, and updated search highlighting to use query parameters |
packages/web-app-admin-settings/tests/unit/views/Groups.spec.ts |
Added test for search functionality with mocked router |
packages/web-app-admin-settings/tests/unit/components/Groups/GroupsList.spec.ts |
Added router mocks to support component changes |
changelog/unreleased/enhancement-use-api-groups-search-in-admin.md |
Documented the enhancement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/web-app-admin-settings/src/components/Groups/GroupsList.vue
Outdated
Show resolved
Hide resolved
This changes the search behaviour in the admin settings. Instead of filtering the groups in the client, we now use the search parameter of the list groups API endpoint.
LukasHirt
force-pushed
the
feat/groups-api-search
branch
from
6184aab to
1590f4b
Compare
|
mzner
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the search behaviour in the admin settings. Instead of filtering the groups in the client, we now use the search parameter of the list groups API endpoint.
Motivation and Context
Leave the search to the API and don't slow down the browser.
How Has This Been Tested?
Screenshots (if appropriate):
Zaznam.obrazovky.2025-10-23.v.11.53.50.mov
Types of changes