fix: [OCISDEV-431] include ubuntu font #13233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've included the Ubuntu font in the web container. This fixed the issue where the Ubuntu font was not being loaded in the PDF export due to CSP restrictions. The font is distributed under the open licence. https://canonical.com/legal/font-licence
There was a problem hiding this comment.
Pull Request Overview
This PR resolves PDF export issues by bundling Ubuntu fonts locally instead of fetching them from external URLs, which were blocked by CSP restrictions. The fonts are included under the Ubuntu Font Licence 1.0.
- Updated font URLs to point to local
/fonts/ubuntu/directory - Added Ubuntu font files and comprehensive licensing documentation
- Created changelog entry documenting the fix
Reviewed Changes
Copilot reviewed 9 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-pkg/src/composables/webWorkers/exportAsPdfWorker/renderer.ts | Changed font URLs from external https://pdf-lib.js.org to local /fonts/ubuntu/ paths |
| packages/web-container/fonts/ubuntu/copyright.md | Added copyright notice for Ubuntu fonts |
| packages/web-container/fonts/ubuntu/TRADEMARKS.md | Added trademark information |
| packages/web-container/fonts/ubuntu/README.md | Added Ubuntu Font Family introduction and project information |
| packages/web-container/fonts/ubuntu/LICENCE-FAQ.md | Added detailed licensing FAQ documentation |
| packages/web-container/fonts/ubuntu/LICENCE | Added Ubuntu Font Licence Version 1.0 full text |
| packages/web-container/fonts/ubuntu/FONTLOG.md | Added comprehensive font changelog and acknowledgements |
| packages/web-container/fonts/ubuntu/CONTRIBUTING.md | Added contribution guidelines |
| changelog/unreleased/bugfix-include-ubuntu-font.md | Added changelog entry describing the fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mzner
approved these changes
Oct 23, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've included the Ubuntu font in the web container. This fixed the issue where the Ubuntu font was not being loaded in the PDF export due to CSP restrictions. The font is distributed under the open licence.
https://canonical.com/legal/font-licence
Motivation and Context
PDF export works without touching CSP configuration.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes