bugfix(web-pkg, web-runtime): [OCISDEV-418] add global error store and watch for global errors #13223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzner
force-pushed
the
bugfix/OCISDEV-418/loading-spinner-keeps-running-when-resource-is-deleted
branch
from
61b9800 to
ca129e5
Compare
8 tasks
LukasHirt
reviewed
Oct 20, 2025
| () => appStore.error, | ||
| () => { | ||
| if (appStore.error) { | ||
| // console.log('erro: ', appStore.error) |
| watch( | ||
| () => authStore.publicLinkContextReady, | ||
| async (publicLinkContextReady) => { | ||
| appStore.error = null |
Collaborator
There was a problem hiding this comment.
Wouldn't this be better if it's in some more global place? What if I go back and try to open a non-deleted file? Wouldn't I still get the error?
…d watch for global errors
mzner
force-pushed
the
bugfix/OCISDEV-418/loading-spinner-keeps-running-when-resource-is-deleted
branch
from
ca129e5 to
76f9c03
Compare
LukasHirt
approved these changes
Oct 20, 2025
|
mzner
deleted the
bugfix/OCISDEV-418/loading-spinner-keeps-running-when-resource-is-deleted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: