fix: [OCISDEV-433] do not disable sharing of resources when managing spaces via claims #13213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spaces via claims When managing spaces via claims, we were disabling sharing of resources when the server managed spaces capability was enabled. This was not correct, as we should only disable sharing of spaces.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where sharing of all resources was incorrectly disabled when server-managed spaces capability was enabled. The fix ensures that only space resources have sharing disabled under this capability, while regular resources remain shareable.
Key changes:
- Moved the server-managed spaces check to only apply to space resources
- Added comprehensive test coverage for the corrected behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/web-pkg/src/composables/shares/useCanShare.ts | Refactored logic to check for server-managed spaces only when the resource is a space type |
| packages/web-pkg/tests/unit/composables/shares/useCanShare.spec.ts | Added test suite covering space and non-space resource sharing scenarios with server-managed spaces enabled/disabled |
| changelog/unreleased/bugfix-do-not-disable-sharing-of-resources-when-managing-spaces-via-claims.md | Documented the bugfix for the changelog |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
mzner
approved these changes
Oct 17, 2025
This was referenced Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When managing spaces via claims, we were disabling sharing of resources when the server managed spaces capability was enabled. This was not correct, as we should only disable sharing of spaces.
Motivation and Context
The capability should affect only spaces.
How Has This Been Tested?
OCIS_CLAIM_MANAGED_SPACES_ENABLEDtotrueand try to share a resourceOCIS_CLAIM_MANAGED_SPACES_ENABLEDtotrueand try to add members into a spaceOCIS_CLAIM_MANAGED_SPACES_ENABLEDtofalseand try to share a resourceOCIS_CLAIM_MANAGED_SPACES_ENABLEDtofalseand try to add members into a spaceTypes of changes