bugfix(web-app-activities, web-app-files, web-runtime): [OCISDEV-420] fix incorrect translations #13198
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
mzner
force-pushed
the
bugfix/OCISDEV-420/missing-translations
branch
from
1923500 to
7950921
Compare
mzner
force-pushed
the
bugfix/OCISDEV-420/missing-translations
branch
from
7950921 to
895ae89
Compare
| import { ConfigStore } from '@ownclouders/web-pkg' | ||
| import { useGettext } from 'vue3-gettext' | ||
|
|
||
| export const useContextualHelpers = (configStore: MaybeRef<ConfigStore>) => { |
There was a problem hiding this comment.
Why is the configStore a parameter instead of using the pinia composable here?
There was a problem hiding this comment.
Just a preference instead of having the file depend on it -- it is more flexible when it is being passed. Can switch if you prefer. What do you think?
There was a problem hiding this comment.
I usually choose simplicity over flexibility. I.e. if a composable is dependent on a store which will not be different if it's called from component A or component B, I don't want to always have to pass it instead of having it once in the composable directly. If it would be some data that might change depending on the place where the composable is called, then parameters would be of course the way to go for me as well.
However, I don't want to impose my thinking on you so if you prefer it like this, I am fine with leaving it like it is.
| const spaceAddMemberHelp = computed(() => { | ||
| return shareSpaceAddMemberHelp({ configStore: unref(configStore) }) | ||
| }) | ||
| const spaceAddMemberHelp = shareSpaceAddMemberHelp |
There was a problem hiding this comment.
Let's use it directly instead of wrapping it in the extra const?
| const indirectLinkHelp = computed(() => { | ||
| return shareViaIndirectLinkHelp({ configStore }) | ||
| }) | ||
| const viaLinkHelp = shareViaLinkHelp |
There was a problem hiding this comment.
Let's use it directly instead of wrapping it in the extra const?
| return shareViaIndirectLinkHelp({ configStore }) | ||
| }) | ||
| const viaLinkHelp = shareViaLinkHelp | ||
| const indirectLinkHelp = shareViaIndirectLinkHelp |
There was a problem hiding this comment.
Let's use it directly instead of wrapping it in the extra const?
|
|
||
| // just a dummy function to trick gettext tools | ||
| function $gettext(msg: string) { | ||
| return msg | ||
| const { $gettext: getText } = useGettext() |
There was a problem hiding this comment.
Would it be safe to completely remove this file? If not, I would at least revert this specific change and keep it as it was.
There was a problem hiding this comment.
I would say so. I searched the project and replaced where it has been used, but never say never. I will bring it back. :D
There was a problem hiding this comment.
Up to you. web-app-files is not published anywhere and is "only" bundled directly with Web, so if it's not used in this repo, there shouldn't be any other place that would use it. If you decide to keep this, it would be great to mark the exported code as deprecated using jsdocs though to make it clear it's not supposed to be used anymore.
mzner
force-pushed
the
bugfix/OCISDEV-420/missing-translations
branch
2 times, most recently
from
5851bf5 to
188d3d0
Compare
| <span class="oc-ml-s" v-text="activity.template.variables?.user?.displayName" /> | ||
| </div> | ||
| <div>activity unknown</div> | ||
| <div>{{ $gettext('activity unknown') }}</div> |
There was a problem hiding this comment.
Since you're touching this and it will get synced to transifex, could you please double check whether it is correct behaviour that it starts with lowercase a? Feels a bit odd. Just to make sure that we push the correct string into transifex.
… fix incorrect translations
mzner
force-pushed
the
bugfix/OCISDEV-420/missing-translations
branch
from
188d3d0 to
84a9f9e
Compare
|
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: