feat: [OCISDEV-354] hide trashed spaces #13168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements functionality to hide trashed spaces from the UI by filtering out spaces with root.deleted.state set to 'trashed'. This applies to both personal and project spaces.
- Adds filtering logic to exclude trashed spaces in the
getSpacesByTypefunction - Introduces a
SpaceDeletedStateenum for better type safety - Includes comprehensive test coverage for the new filtering behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/web-pkg/src/composables/piniaStores/spaces.ts | Implements filtering logic to exclude spaces with trashed state |
| packages/web-pkg/tests/unit/composables/piniaStores/spaces.spec.ts | Adds test case to verify trashed spaces are filtered out |
| packages/web-client/src/helpers/space/types.ts | Defines SpaceDeletedState enum for type safety |
| changelog/unreleased/enhancement-hide-trashed-spaces.md | Documents the enhancement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mzner
approved these changes
Oct 7, 2025
If the `root.deleted.state` property of a space is `trashed`, the space is not shown in the UI. This includes also personal spaces.
LukasHirt
force-pushed
the
feat/hide-disabled-spaces
branch
from
55b459c to
bef280e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the
root.deleted.stateproperty of a space istrashed, the space is not shown in the UI. This includes also personal spaces.Motivation and Context
User does not see disabled spaces.
How Has This Been Tested?
User Light, open the UI again with that userTypes of changes