feat: [OCISDEV-230] poc, /admin-settings OTP #12942
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
|
|
There is already a PR in progress for this #12925 |
|
|
||
| // Avoid re-triggering when returning from step-up or when a request is already in-flight for this route | ||
| const hasStepupParam = !!to.query.stepup | ||
| const hasGlobalStepupFlag = new URLSearchParams(window.location.search).has('stepupAcr') |
There was a problem hiding this comment.
Why use query? Shouldn't this be dependent on capabilities based on the requirements?
There was a problem hiding this comment.
Yes, should be mandatory, latest version is mandatory. The query was for sake of easier testing the PoC
| name: 'admin-settings-general', | ||
| component: General, | ||
| beforeEnter: (to, from, next) => { | ||
| if (!$ability.can('read-all', 'Setting')) { |
There was a problem hiding this comment.
Seems this is lost in the new guard?
| extraQueryParams: { | ||
| acr_values: acr, | ||
| prompt: 'login', | ||
| max_age: 0 |
There was a problem hiding this comment.
Shouldn't the max_age be defined in the auth flow?
| const redirectRoute = this.router.resolve(this.userManager.getAndClearPostLoginRedirectUrl()) | ||
| const postRedirectUrl = this.userManager.getAndClearPostLoginRedirectUrl() | ||
| try { | ||
| sessionStorage.setItem('oc.postStepupRedirectUrl', postRedirectUrl) |
mklos-kw
force-pushed
the
poc-admin-otp
branch
from
04bb8ea to
18de60f
Compare
mklos-kw
changed the title
Description
Show OTP on /admin-settings:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: