fix(web-app-external): add src to iframe #12598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug with permission propagation by adding a dynamic "src" attribute to the external app iframe.
- Added a binding for the "src" attribute using "appUrl" in the App.vue file.
- Updated the changelog with details regarding the bug fix and related issues.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/web-app-external/src/App.vue | Added the ":src" attribute binding to ensure permissions are correctly propagated |
| changelog/unreleased/bugfix-add-src-attribute-to-external-app-iframe.md | Documented the bug fix and provided context with internal links and issue references |
mzner
approved these changes
May 23, 2025
Added attribute to the iframe when using requests to make sure that permissions are correctly propagated to the final destination.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added attribute to the iframe when using requests to make sure that permissions are correctly propagated to the final destination.
Related Issue
Motivation and Context
Permissions are working as expected.
How Has This Been Tested?
Types of changes