fix(password-protected-folders): create folder in the personal space #12146

LukasHirt · 2025-01-30T11:13:06Z

Description

Create the hidden folder in users personal space

Related Issue

refs Password Protected Folders #12039

Motivation and Context

Other users cannot access the folder without the pass

How Has This Been Tested?

test environment: chrome & 🤖
test case 1: Create a password protected folder in users personal space
test case 2: Create a password protected folder in created space

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests
Documentation
Maintenance (e.g. dependency updates or tooling)

saw-jan · 2025-02-04T04:24:36Z

packages/web-app-password-protected-folders/src/composables/useCreateFileHandler.ts

    }

    const folderPath = '/.' + fileName
+    const folder = await clientService.webdav.createFolder(personalSpace, { path: folderPath })


does this mean if a protected folder is created in any project space, the folder (hidden folder) will be created in the creator's personal space?

Also if I create test1 folder in my personal space. and try to create test1 in project space, it doesn't allow creation of test1 in the project space.

does this mean if a protected folder is created in any project space, the folder (hidden folder) will be created in the creator's personal space?

That is correct and intended behaviour for this feature.

Also if I create test1 folder in my personal space. and try to create test1 in project space, it doesn't allow creation of test1 in the project space.

Hmm, I'll handle this, thanks!

It is not optimal solution but I think in this case it would be fine to have this limitation and simply force the user to rename it. The hidden folder name needs to currently match the .psec file name as it is used when deleting the file and folder together. Meaning adding some suffix to the folder name would break the deletion then. So in favor of keeping this feature technically simple, I would say forcing the user to have unique name is fine. What do you say @kobergj

Isn't the folder in the personal space under .PasswordProtectedFolders/projects/<space_name>? So that would mean a user needs to create the exact same folder structure (including the space name) to achieve a name clash?

🤦 and of course I missed this requirement... you are right. I will look into this asap.

hmm, I thought something changed internally in the requirements and I didn't ask about it while reviewing. should have just asked it.

sonarqubecloud · 2025-02-12T11:27:52Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

saw-jan

implementation of this PR works. 👍
folders are created inside .PasswordProtectedFolders/projects/{space-name} dir

LukasHirt added the Type:Bug Something isn't working label Jan 30, 2025

LukasHirt requested a review from saw-jan January 30, 2025 11:13

LukasHirt self-assigned this Jan 30, 2025

LukasHirt force-pushed the fix/psec-folder-location branch from ec23448 to fe726bd Compare February 3, 2025 09:59

saw-jan reviewed Feb 4, 2025

View reviewed changes

LukasHirt force-pushed the fix/psec-folder-location branch from fe726bd to bab1237 Compare February 10, 2025 09:32

LukasHirt requested a review from saw-jan February 10, 2025 09:32

LukasHirt mentioned this pull request Feb 10, 2025

[QA] Test Password Protected Folders #12181

Closed

10 tasks

LukasHirt force-pushed the fix/psec-folder-location branch from bab1237 to 3dab655 Compare February 12, 2025 10:29

fix(password-protected-folders): create folder in the personal space

b65d3ed

LukasHirt force-pushed the fix/psec-folder-location branch from 3dab655 to b65d3ed Compare February 12, 2025 10:40

LukasHirt enabled auto-merge February 12, 2025 11:45

saw-jan approved these changes Feb 12, 2025

View reviewed changes

LukasHirt merged commit bb34008 into master Feb 12, 2025
4 checks passed

LukasHirt deleted the fix/psec-folder-location branch February 12, 2025 11:51

LukasHirt mentioned this pull request Feb 13, 2025

Release 11.2.0 #12180

Closed

25 tasks

renovate bot mentioned this pull request Jun 12, 2025

chore(deps): update dependency @ownclouders/eslint-config to v12 owncloud/web-app-skeleton#67

Merged

1 task

fix(password-protected-folders): create folder in the personal space #12146

fix(password-protected-folders): create folder in the personal space #12146

Uh oh!

Conversation

LukasHirt commented Jan 30, 2025

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 12, 2025

Quality Gate passed

Uh oh!

saw-jan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants