Skip to content

Conversation

@LukasHirt
Copy link
Collaborator

Description

When an app does not expose any routes, mark it as editor-less so that we do not try to load editor actions for such extension.

Motivation and Context

Extension without editor does not break the app.

How Has This Been Tested?

  • test environment: chrome & 🤖
  • test case 1: manually add extension without any routes and open sidebar
  • test case 2: extend existing unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Jan 16, 2025
@LukasHirt LukasHirt requested a review from saw-jan January 16, 2025 10:41
@LukasHirt LukasHirt self-assigned this Jan 16, 2025
@LukasHirt LukasHirt marked this pull request as draft January 16, 2025 10:59
@LukasHirt
Copy link
Collaborator Author

Let's post-pone this as I might be using the wrong extension type to achieve what I need...

When an app does not expose any routes, mark it as editor-less so that we do not try to load editor actions for such extension.
@LukasHirt LukasHirt force-pushed the feat/editorless-extensions branch from 59e4980 to 487e54e Compare January 23, 2025 09:21
@LukasHirt LukasHirt marked this pull request as ready for review January 23, 2025 09:22
@LukasHirt
Copy link
Collaborator Author

I double checked it and I do not see any other way to achieve create file action without automatically creating an editor for it.

@sonarqubecloud
Copy link

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LukasHirt LukasHirt merged commit 7c7887a into master Jan 23, 2025
4 checks passed
@LukasHirt LukasHirt deleted the feat/editorless-extensions branch January 23, 2025 10:58
spiceratops added a commit to spiceratops/k8s-gitops that referenced this pull request Mar 6, 2025
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker.io/owncloud/ocis](https://redirect.github.com/owncloud/ocis) |
minor | `7.0.1` -> `7.1.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>owncloud/ocis (docker.io/owncloud/ocis)</summary>

###
[`v7.1.0`](https://redirect.github.com/owncloud/ocis/blob/HEAD/CHANGELOG.md#Changelog-for-710-2025-03-06)

[Compare
Source](https://redirect.github.com/owncloud/ocis/compare/v7.0.1...v7.1.0)

The following sections list the changes for 7.1.0.

[7.1.0]:
https://redirect.github.com/owncloud/ocis/compare/v7.0.0...v7.1.0

#### Summary

- Bugfix - Update govips to 2.16.0:
[#&#8203;10378](https://redirect.github.com/owncloud/ocis/issues/10378)
- Bugfix - Share creation date is missing in invite response:
[#&#8203;10781](https://redirect.github.com/owncloud/ocis/pull/10781)
- Bugfix - Bump some golang dependencies:
[#&#8203;10795](https://redirect.github.com/owncloud/ocis/pull/10795)
- Bugfix - Allow to accepted invite after it was once deleted:
[#&#8203;10834](https://redirect.github.com/owncloud/ocis/pull/10834)
- Bugfix - Fix the mail notifications for the user light:
[#&#8203;10865](https://redirect.github.com/owncloud/ocis/pull/10865)
- Bugfix - Fix filtering of PostprocessingStepFinished events:
[#&#8203;10868](https://redirect.github.com/owncloud/ocis/pull/10868)
- Bugfix - Prevent empty email body for grouped email notifications:
[#&#8203;10869](https://redirect.github.com/owncloud/ocis/pull/10869)
- Bugfix - Consistently name roles:
[#&#8203;10871](https://redirect.github.com/owncloud/ocis/pull/10871)
- Bugfix - Fix grouped email notifications store key:
[#&#8203;10873](https://redirect.github.com/owncloud/ocis/pull/10873)
- Bugfix - Fix missing newline in grouped email:
[#&#8203;10883](https://redirect.github.com/owncloud/ocis/pull/10883)
- Bugfix - Fix email templates white spaces & new lines:
[#&#8203;10884](https://redirect.github.com/owncloud/ocis/pull/10884)
- Bugfix - Fix the ocm gateway connection pool:
[#&#8203;10916](https://redirect.github.com/owncloud/ocis/pull/10916)
- Bugfix - Add fallback for folder names:
[#&#8203;10932](https://redirect.github.com/owncloud/ocis/pull/10932)
- Bugfix - Allow view ocm shares:
[#&#8203;10944](https://redirect.github.com/owncloud/ocis/pull/10944)
- Bugfix - Fix Collaboration file extension check:
[#&#8203;10947](https://redirect.github.com/owncloud/ocis/issues/10947)
- Bugfix - Add Identities to education user:
[#&#8203;11016](https://redirect.github.com/owncloud/ocis/pull/11016)
- Bugfix - Bump libregraph api:
[#&#8203;11021](https://redirect.github.com/owncloud/ocis/pull/11021)
- Bugfix - Fix OCM create share:
[#&#8203;11047](https://redirect.github.com/owncloud/ocis/pull/11047)
- Bugfix - Fix update grants for the OCM share:
[#&#8203;11052](https://redirect.github.com/owncloud/ocis/pull/11052)
- Enhancement - Part I: The user settings are extended by notifications
preferences:
[#&#8203;10706](https://redirect.github.com/owncloud/ocis/pull/10706)
- Enhancement - Part II: Filtering of in-app notifications:
[#&#8203;10779](https://redirect.github.com/owncloud/ocis/pull/10779)
- Enhancement - Part III: Filtering of mail notifications:
[#&#8203;10792](https://redirect.github.com/owncloud/ocis/pull/10792)
- Enhancement - Translate Notification Settings:
[#&#8203;10812](https://redirect.github.com/owncloud/ocis/pull/10812)
- Enhancement - Part IV: Grouping of mail notifications:
[#&#8203;10838](https://redirect.github.com/owncloud/ocis/pull/10838)
- Enhancement - Update web to v11.1.0:
[#&#8203;10853](https://redirect.github.com/owncloud/ocis/pull/10853)
- Enhancement - Add tests for grouped emails:
[#&#8203;10885](https://redirect.github.com/owncloud/ocis/pull/10885)
- Enhancement - Use maintained forks:
[#&#8203;10886](https://redirect.github.com/owncloud/ocis/pull/10886)
- Enhancement - Add email notification for share removed event:
[#&#8203;10915](https://redirect.github.com/owncloud/ocis/pull/10915)
- Enhancement - Update Web to v1.11.1:
[#&#8203;10918](https://redirect.github.com/owncloud/ocis/pull/10918)
- Enhancement - Update Web to v1.11.2:
[#&#8203;10930](https://redirect.github.com/owncloud/ocis/pull/10930)
- Enhancement - Implement debug docker for arm64 platform:
[#&#8203;10940](https://redirect.github.com/owncloud/ocis/pull/10940)
- Enhancement - Add roles:
[#&#8203;10964](https://redirect.github.com/owncloud/ocis/pull/10964)
- Enhancement - Update Web to v1.11.3:
[#&#8203;10977](https://redirect.github.com/owncloud/ocis/pull/10977)
- Enhancement - Add the ocm notification handler:
[#&#8203;11005](https://redirect.github.com/owncloud/ocis/pull/11005)
- Enhancement - Add logging when a users space gets deleted:
[#&#8203;11037](https://redirect.github.com/owncloud/ocis/pull/11037)
- Enhancement - Add the ocm notification ShareChangePermission:
[#&#8203;11041](https://redirect.github.com/owncloud/ocis/pull/11041)
- Enhancement - Update Web to v11.2.0:
[#&#8203;11049](https://redirect.github.com/owncloud/ocis/pull/11049)
- Enhancement - Update Web to v11.3.0:
[#&#8203;11058](https://redirect.github.com/owncloud/ocis/pull/11058)
- Enhancement - Bump Reva:
[#&#8203;11083](https://redirect.github.com/owncloud/ocis/pull/11083)

#### Details

- Bugfix - Update govips to 2.16.0:
[#&#8203;10378](https://redirect.github.com/owncloud/ocis/issues/10378)

The update to govips 2.16.0 removes temporary access to /tmp that was
introduced
    by govips.


[https://github.com/owncloud/ocis/issues/10378](https://redirect.github.com/owncloud/ocis/issues/10378)

[https://github.com/owncloud/ocis/pull/10943](https://redirect.github.com/owncloud/ocis/pull/10943)0943

- Bugfix - Share creation date is missing in invite response:
[#&#8203;10781](https://redirect.github.com/owncloud/ocis/pull/10781)

The graph drives invite response now includes the `createdDateTime`
field.


[https://github.com/owncloud/ocis/issues/10739](https://redirect.github.com/owncloud/ocis/issues/10739)

[https://github.com/owncloud/ocis/pull/10781](https://redirect.github.com/owncloud/ocis/pull/10781)0781

- Bugfix - Bump some golang dependencies:
[#&#8203;10795](https://redirect.github.com/owncloud/ocis/pull/10795)

    Bump dependencies "golang.org/x/crypto" and "golang.org/x/net"


[https://github.com/owncloud/ocis/pull/10795](https://redirect.github.com/owncloud/ocis/pull/10795)

- Bugfix - Allow to accepted invite after it was once deleted:
[#&#8203;10834](https://redirect.github.com/owncloud/ocis/pull/10834)

Allowed to accepted invite even after it was once deleted on the invite
receiver
    or invite creation side.


[https://github.com/owncloud/ocis/issues/10813](https://redirect.github.com/owncloud/ocis/issues/10813)

[https://github.com/owncloud/ocis/pull/10834](https://redirect.github.com/owncloud/ocis/pull/10834)0834

- Bugfix - Fix the mail notifications for the user light:
[#&#8203;10865](https://redirect.github.com/owncloud/ocis/pull/10865)

Fix the default bundle-list for mail notification settings for the user
light.


[https://github.com/owncloud/ocis/issues/10864](https://redirect.github.com/owncloud/ocis/issues/10864)

[https://github.com/owncloud/ocis/pull/10865](https://redirect.github.com/owncloud/ocis/pull/10865)0865

- Bugfix - Fix filtering of PostprocessingStepFinished events:
[#&#8203;10868](https://redirect.github.com/owncloud/ocis/pull/10868)


[https://github.com/owncloud/ocis/issues/10867](https://redirect.github.com/owncloud/ocis/issues/10867)

[https://github.com/owncloud/ocis/pull/10868](https://redirect.github.com/owncloud/ocis/pull/10868)0868

- Bugfix - Prevent empty email body for grouped email notifications:
[#&#8203;10869](https://redirect.github.com/owncloud/ocis/pull/10869)


[https://github.com/owncloud/ocis/pull/10869](https://redirect.github.com/owncloud/ocis/pull/10869)

- Bugfix - Consistently name roles:
[#&#8203;10871](https://redirect.github.com/owncloud/ocis/pull/10871)

BundleUUIDRoleGuest has been renamed to BundleUUIDRoleUserLight for
consistency
    reasons


[https://github.com/owncloud/ocis/pull/10871](https://redirect.github.com/owncloud/ocis/pull/10871)

- Bugfix - Fix grouped email notifications store key:
[#&#8203;10873](https://redirect.github.com/owncloud/ocis/pull/10873)

    Interval and user id is now separated by `_` (key schema:
    `${INTERVAL}_${USER_ID}`).


[https://github.com/owncloud/ocis/pull/10873](https://redirect.github.com/owncloud/ocis/pull/10873)

- Bugfix - Fix missing newline in grouped email:
[#&#8203;10883](https://redirect.github.com/owncloud/ocis/pull/10883)

    `\n` is now replaced by `<br>` in the HTML email body


[https://github.com/owncloud/ocis/pull/10883](https://redirect.github.com/owncloud/ocis/pull/10883)

- Bugfix - Fix email templates white spaces & new lines:
[#&#8203;10884](https://redirect.github.com/owncloud/ocis/pull/10884)

    Email templates now contain no unwanted white spaces & new lines if
    .CallToAction is nil


[https://github.com/owncloud/ocis/pull/10884](https://redirect.github.com/owncloud/ocis/pull/10884)

- Bugfix - Fix the ocm gateway connection pool:
[#&#8203;10916](https://redirect.github.com/owncloud/ocis/pull/10916)

Fix the ocm gateway connection pool. Fix ocis dependency in the reva
go.mod
    file. Bump the ocis version accordingly to the major version.


[https://github.com/owncloud/ocis/issues/10846](https://redirect.github.com/owncloud/ocis/issues/10846)

[https://github.com/owncloud/ocis/issues/10878](https://redirect.github.com/owncloud/ocis/issues/10878)0[https://github.com/owncloud/ocis/pull/10916](https://redirect.github.com/owncloud/ocis/pull/10916)ll/10916

- Bugfix - Add fallback for folder names:
[#&#8203;10932](https://redirect.github.com/owncloud/ocis/pull/10932)

Add translated `shared-with-me` fallback for folder names in the
activitylog to
    avoid `{folder}` in the output.


[https://github.com/owncloud/ocis/issues/10906](https://redirect.github.com/owncloud/ocis/issues/10906)

[https://github.com/owncloud/ocis/pull/10932](https://redirect.github.com/owncloud/ocis/pull/10932)0932

- Bugfix - Allow view ocm shares:
[#&#8203;10944](https://redirect.github.com/owncloud/ocis/pull/10944)

OCM shares with `view` permissions did not work. When opening them in
weboffice
    an error would occur. This has been fixed.


[https://github.com/owncloud/ocis/pull/10944](https://redirect.github.com/owncloud/ocis/pull/10944)

- Bugfix - Fix Collaboration file extension check:
[#&#8203;10947](https://redirect.github.com/owncloud/ocis/issues/10947)

Fixed Collaboration file extension check to case-insensitive comparison.


[https://github.com/owncloud/ocis/issues/10947](https://redirect.github.com/owncloud/ocis/issues/10947)

[https://github.com/owncloud/ocis/pull/10945](https://redirect.github.com/owncloud/ocis/pull/10945)0945

- Bugfix - Add Identities to education user:
[#&#8203;11016](https://redirect.github.com/owncloud/ocis/pull/11016)

Education User where not created correctly. They were missing the
Identities
    field


[https://github.com/owncloud/ocis/pull/11016](https://redirect.github.com/owncloud/ocis/pull/11016)

- Bugfix - Bump libregraph api:
[#&#8203;11021](https://redirect.github.com/owncloud/ocis/pull/11021)

    Bump the libregraph api to avoid a regression.


[https://github.com/owncloud/ocis/pull/11021](https://redirect.github.com/owncloud/ocis/pull/11021)

- Bugfix - Fix OCM create share:
[#&#8203;11047](https://redirect.github.com/owncloud/ocis/pull/11047)

We fixed the OCM share fails on share creating if the federated instance
is not
    reachable.


[https://github.com/owncloud/ocis/issues/11046](https://redirect.github.com/owncloud/ocis/issues/11046)

[https://github.com/owncloud/ocis/pull/11047](https://redirect.github.com/owncloud/ocis/pull/11047)1047

- Bugfix - Fix update grants for the OCM share:
[#&#8203;11052](https://redirect.github.com/owncloud/ocis/pull/11052)

    Fix update grants for the OCM share


[https://github.com/owncloud/ocis/issues/11022](https://redirect.github.com/owncloud/ocis/issues/11022)

[https://github.com/owncloud/ocis/pull/11052](https://redirect.github.com/owncloud/ocis/pull/11052)1052

- Enhancement - Part I: The user settings are extended by notifications
preferences:
[#&#8203;10706](https://redirect.github.com/owncloud/ocis/pull/10706)

Part I: Users can now store their notifications preferences in the user
settings


[https://github.com/owncloud/ocis/issues/10669](https://redirect.github.com/owncloud/ocis/issues/10669)

[https://github.com/owncloud/ocis/pull/10706](https://redirect.github.com/owncloud/ocis/pull/10706)0706

- Enhancement - Part II: Filtering of in-app notifications:
[#&#8203;10779](https://redirect.github.com/owncloud/ocis/pull/10779)

Part II: In-app notifications are now filtered based on the notification
    preferences in the user settings


[https://github.com/owncloud/ocis/issues/10769](https://redirect.github.com/owncloud/ocis/issues/10769)

[https://github.com/owncloud/ocis/pull/10779](https://redirect.github.com/owncloud/ocis/pull/10779)0779

- Enhancement - Part III: Filtering of mail notifications:
[#&#8203;10792](https://redirect.github.com/owncloud/ocis/pull/10792)

Part III: Mail notifications are now filtered based on the notification
    preferences in the user settings


[https://github.com/owncloud/ocis/issues/10790](https://redirect.github.com/owncloud/ocis/issues/10790)

[https://github.com/owncloud/ocis/pull/10792](https://redirect.github.com/owncloud/ocis/pull/10792)0792

- Enhancement - Translate Notification Settings:
[#&#8203;10812](https://redirect.github.com/owncloud/ocis/pull/10812)

Translates the notification settings according to the users language
preference.


[https://github.com/owncloud/ocis/pull/10812](https://redirect.github.com/owncloud/ocis/pull/10812)

- Enhancement - Part IV: Grouping of mail notifications:
[#&#8203;10838](https://redirect.github.com/owncloud/ocis/pull/10838)

Part IV: Mail notifications can now be grouped on a daily or weekly
basis


[https://github.com/owncloud/ocis/issues/10793](https://redirect.github.com/owncloud/ocis/issues/10793)

[https://github.com/owncloud/ocis/pull/10838](https://redirect.github.com/owncloud/ocis/pull/10838)0838

- Enhancement - Update web to v11.1.0:
[#&#8203;10853](https://redirect.github.com/owncloud/ocis/pull/10853)

- Bugfix
[owncloud/web#12040](https://redirect.github.com/owncloud/web/pull/12040):
Preview app files visibility:
[#&#8203;12040](https://redirect.github.com/owncloud/ocis/issues/12040)
- Bugfix

[owncloud/web#12044](https://redirect.github.com/owncloud/web/pull/12044):
Disable paste
action in same folder:
[#&#8203;12044](https://redirect.github.com/owncloud/ocis/issues/12044)
- Bugfix

[owncloud/web#12045](https://redirect.github.com/owncloud/web/pull/12045):
Do not push
sidebar close action away:
[#&#8203;12045](https://redirect.github.com/owncloud/ocis/issues/12045)
- Bugfix

[owncloud/web#12045](https://redirect.github.com/owncloud/web/pull/12045):
Update sidebar
width on resize:
[#&#8203;12045](https://redirect.github.com/owncloud/ocis/issues/12045)
- Bugfix

[owncloud/web#12045](https://redirect.github.com/owncloud/web/pull/12045):
Use correct
breakpoints in sidebar:
[#&#8203;12045](https://redirect.github.com/owncloud/ocis/issues/12045)
- Bugfix

[owncloud/web#12050](https://redirect.github.com/owncloud/web/pull/12050):
Show indirect
shares on search page:
[#&#8203;12050](https://redirect.github.com/owncloud/ocis/issues/12050)
- Bugfix

[owncloud/web#12055](https://redirect.github.com/owncloud/web/pull/12055):
Add more
padding to input when clear action is visible:
[#&#8203;12055](https://redirect.github.com/owncloud/ocis/issues/12055)
- Bugfix

[owncloud/web#12058](https://redirect.github.com/owncloud/web/pull/12058):
Use local
state in sidebar in embed mode:
[#&#8203;12058](https://redirect.github.com/owncloud/ocis/issues/12058)
- Bugfix

[owncloud/web#12063](https://redirect.github.com/owncloud/web/pull/12063):
Change opacity
of disabled checkboxes:
[#&#8203;12063](https://redirect.github.com/owncloud/ocis/issues/12063)
- Bugfix

[owncloud/web#12074](https://redirect.github.com/owncloud/web/pull/12074):
Refetch
notifications settings on locale change:
[#&#8203;12074](https://redirect.github.com/owncloud/ocis/issues/12074)
- Enhancement

[owncloud/web#12010](https://redirect.github.com/owncloud/web/pull/12010):
Add
notifications settings:
[#&#8203;12010](https://redirect.github.com/owncloud/ocis/issues/12010)
- Enhancement

[owncloud/web#12054](https://redirect.github.com/owncloud/web/pull/12054):
Use generic
private link error:
[#&#8203;12054](https://redirect.github.com/owncloud/ocis/issues/12054)


[https://github.com/owncloud/ocis/pull/10853](https://redirect.github.com/owncloud/ocis/pull/10853)
    https://github.com/owncloud/web/releases/tag/v11.1.0

- Enhancement - Add tests for grouped emails:
[#&#8203;10885](https://redirect.github.com/owncloud/ocis/pull/10885)


[https://github.com/owncloud/ocis/pull/10885](https://redirect.github.com/owncloud/ocis/pull/10885)

- Enhancement - Use maintained forks:
[#&#8203;10886](https://redirect.github.com/owncloud/ocis/pull/10886)

    Switches away from unmainatained forks.


[https://github.com/owncloud/ocis/pull/10886](https://redirect.github.com/owncloud/ocis/pull/10886)

- Enhancement - Add email notification for share removed event:
[#&#8203;10915](https://redirect.github.com/owncloud/ocis/pull/10915)


[https://github.com/owncloud/ocis/issues/10904](https://redirect.github.com/owncloud/ocis/issues/10904)

[https://github.com/owncloud/ocis/pull/10915](https://redirect.github.com/owncloud/ocis/pull/10915)0915

- Enhancement - Update Web to v1.11.1:
[#&#8203;10918](https://redirect.github.com/owncloud/ocis/pull/10918)

- Bugfix
[owncloud/web#12112](https://redirect.github.com/owncloud/web/pull/12112):
Optionally access preview app route query:
[#&#8203;12112](https://redirect.github.com/owncloud/ocis/issues/12112)
- Bugfix

[owncloud/web#12118](https://redirect.github.com/owncloud/web/pull/12118):
Change
federated share icon:
[#&#8203;12118](https://redirect.github.com/owncloud/ocis/issues/12118)
- Bugfix

[owncloud/web#12118](https://redirect.github.com/owncloud/web/pull/12118):
Improve
federated share icon contrast:
[#&#8203;12118](https://redirect.github.com/owncloud/ocis/issues/12118)
- Bugfix

[owncloud/web#12119](https://redirect.github.com/owncloud/web/pull/12119):
Show external
share indicator:
[#&#8203;12119](https://redirect.github.com/owncloud/ocis/issues/12119)


[https://github.com/owncloud/ocis/pull/10918](https://redirect.github.com/owncloud/ocis/pull/10918)
    https://github.com/owncloud/web/releases/tag/v11.1.1

- Enhancement - Update Web to v1.11.2:
[#&#8203;10930](https://redirect.github.com/owncloud/ocis/pull/10930)

- Bugfix
[owncloud/ocis#10891](https://redirect.github.com/owncloud/ocis/issues/10891):
Rename ScienceMesh:
[#&#8203;10891](https://redirect.github.com/owncloud/ocis/issues/10891)


[https://github.com/owncloud/ocis/pull/10930](https://redirect.github.com/owncloud/ocis/pull/10930)
    https://github.com/owncloud/web/releases/tag/v11.1.2

- Enhancement - Implement debug docker for arm64 platform:
[#&#8203;10940](https://redirect.github.com/owncloud/ocis/pull/10940)


[https://github.com/owncloud/ocis/pull/10940](https://redirect.github.com/owncloud/ocis/pull/10940)

- Enhancement - Add roles:
[#&#8203;10964](https://redirect.github.com/owncloud/ocis/pull/10964)

Add EditorListGrantsWithVersions and FileEditorListGrantsWithVersions
roles.


[https://github.com/owncloud/ocis/issues/10747](https://redirect.github.com/owncloud/ocis/issues/10747)

[https://github.com/owncloud/ocis/pull/10964](https://redirect.github.com/owncloud/ocis/pull/10964)0964

- Enhancement - Update Web to v1.11.3:
[#&#8203;10977](https://redirect.github.com/owncloud/ocis/pull/10977)

- Bugfix
[owncloud/web#12156](https://redirect.github.com/owncloud/web/pull/12156):
Replace text editor:
[#&#8203;12156](https://redirect.github.com/owncloud/ocis/issues/12156)


[https://github.com/owncloud/ocis/pull/10977](https://redirect.github.com/owncloud/ocis/pull/10977)
    https://github.com/owncloud/web/releases/tag/v11.1.3

- Enhancement - Add the ocm notification handler:
[#&#8203;11005](https://redirect.github.com/owncloud/ocis/pull/11005)

Added the ocm notification handler that allows receiving a notification
from a
    remote party about changes to a previously known entity.


[https://github.com/owncloud/enterprise/issues/7075](https://redirect.github.com/owncloud/enterprise/issues/7075)

[https://github.com/owncloud/ocis/pull/11005](https://redirect.github.com/owncloud/ocis/pull/11005)1005

- Enhancement - Add logging when a users space gets deleted:
[#&#8203;11037](https://redirect.github.com/owncloud/ocis/pull/11037)

When deleting a user, their personal space will also be deleted. When
this
operation fails the logging in the graph service was insufficient. We
added some
    logs.


[https://github.com/owncloud/ocis/pull/11037](https://redirect.github.com/owncloud/ocis/pull/11037)

- Enhancement - Add the ocm notification ShareChangePermission:
[#&#8203;11041](https://redirect.github.com/owncloud/ocis/pull/11041)

Added the ocm notification ShareChangePermission that allows to
synchronize the
    permissions of a share between the federated instances.


[https://github.com/owncloud/ocis/pull/11041](https://redirect.github.com/owncloud/ocis/pull/11041)

- Enhancement - Update Web to v11.2.0:
[#&#8203;11049](https://redirect.github.com/owncloud/ocis/pull/11049)

- Bugfix
[owncloud/web#12146](https://redirect.github.com/owncloud/web/pull/12146):
        Create password protected folder in personal space - Bugfix

[owncloud/web#12194](https://redirect.github.com/owncloud/web/pull/12194):
Display shared
        file versions - Bugfix

[owncloud/web#12175](https://redirect.github.com/owncloud/web/pull/12175):
Do not render
        default actions in context menu - Bugfix

[owncloud/web#12204](https://redirect.github.com/owncloud/web/pull/12204):
Enable
        external shares editing - Bugfix

[owncloud/web#12177](https://redirect.github.com/owncloud/web/pull/12177):
Open password
        protected folder when clicking on its name - Bugfix

[owncloud/web#12206](https://redirect.github.com/owncloud/web/pull/12206):
Preserve
        current language in password protected folder view - Bugfix

[owncloud/web#12205](https://redirect.github.com/owncloud/web/pull/12205):
Prevent
        password protected folder move - Bugfix

[owncloud/web#12195](https://redirect.github.com/owncloud/web/pull/12195):
Sanitize
        content from md-editor-v3 - Bugfix

[owncloud/web#12178](https://redirect.github.com/owncloud/web/pull/12178):
Skip upload
        dropzone init when files view is missing - Enhancement

[owncloud/web#12206](https://redirect.github.com/owncloud/web/pull/12206):
Add `lang` URL
        query parameter - Enhancement

[owncloud/web#12142](https://redirect.github.com/owncloud/web/pull/12142):
Add password
        protected folders handler - Enhancement

[owncloud/web#12137](https://redirect.github.com/owncloud/web/pull/12137):
Add password
        protected folders app - Enhancement

[owncloud/web#12188](https://redirect.github.com/owncloud/web/pull/12188):
Allow camera
        in external app iframe - Enhancement

[owncloud/web#12142](https://redirect.github.com/owncloud/web/pull/12142):
Control more
        elements visibility via URL query - Enhancement

[owncloud/web#12152](https://redirect.github.com/owncloud/web/pull/12152):
Delete
        password protected folders - Enhancement

[owncloud/web#12046](https://redirect.github.com/owncloud/web/pull/12046):
Disable
        resources in delete queue - Enhancement

[owncloud/web#12145](https://redirect.github.com/owncloud/web/pull/12145):
Display
        default actions in context menu - Enhancement

[owncloud/web#12145](https://redirect.github.com/owncloud/web/pull/12145):
Hide password
        protected folders action - Enhancement

[owncloud/web#12145](https://redirect.github.com/owncloud/web/pull/12145):
Hide password
        protected folders extension - Enhancement

[owncloud/web#12141](https://redirect.github.com/owncloud/web/pull/12141):
Password
        protected folder permissions - Enhancement

[owncloud/web#12146](https://redirect.github.com/owncloud/web/pull/12146):
Recursive
        folder creation


[https://github.com/owncloud/ocis/pull/11049](https://redirect.github.com/owncloud/ocis/pull/11049)
    https://github.com/owncloud/web/releases/tag/v11.2.0

- Enhancement - Update Web to v11.3.0:
[#&#8203;11058](https://redirect.github.com/owncloud/ocis/pull/11058)

- Enhancement
[owncloud/web#12104](https://redirect.github.com/owncloud/web/pull/12104):
        Add psec file icon - Enhancement

[owncloud/web#12105](https://redirect.github.com/owncloud/web/pull/12105):
Handle
        extensions without editor - Enhancement

[owncloud/web#12109](https://redirect.github.com/owncloud/web/pull/12109):
Add custom
        handler to file extensions


[https://github.com/owncloud/ocis/pull/11058](https://redirect.github.com/owncloud/ocis/pull/11058)
    https://github.com/owncloud/web/releases/tag/v11.3.0

- Enhancement - Bump Reva:
[#&#8203;11083](https://redirect.github.com/owncloud/ocis/pull/11083)

    Bumps reva version to 2.27.7


[https://github.com/owncloud/ocis/pull/11083](https://redirect.github.com/owncloud/ocis/pull/11083)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODguNCIsInVwZGF0ZWRJblZlciI6IjM5LjE4OC40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category:Enhancement Add new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants