-
Notifications
You must be signed in to change notification settings - Fork 194
Closed
Labels
Priority:p2-highEscalation, on top of current planning, release blockerEscalation, on top of current planning, release blockerType:BugSomething isn't workingSomething isn't working
Description
Describe the bug
When web makes requests to the previews webdav endpoint, a 429 Too Many Requests error can occur, possibly with a Retry-After header. Web doesn't react with retries at the moment.
Steps to reproduce
- Limit the thumbnail service to 2 concurrent preview image creations via
THUMBNAILS_MAX_CONCURRENT_REQUESTSenv var - Request 10 images via file list
Expected behavior
The failed requests don't get retried.
Actual behavior
The web ui should react to 429 responses with retries.
Additional context
There are several places in the code / ui where preview requests happen and can fail:
- files list
- tiles view
- right sidebar "Details" panel
- preview app (especially in the pre-fetching of images)
All of those requests should be retried if they failed with a 429 status code. If the response has a Retry-After header it should be respected. If it's absent we should come up with a suitable retry offset on our own.
Backend context:
Metadata
Metadata
Assignees
Labels
Priority:p2-highEscalation, on top of current planning, release blockerEscalation, on top of current planning, release blockerType:BugSomething isn't workingSomething isn't working
Type
Projects
Status
Done